The help on the Users page has the following text:
"Drupal allows users to register, login, log out, maintain user profiles, etc. Users of the site may not use their own names to post content until they have signed up for a user account."

I think "login" should instead be "log in", for two reasons:
(1) Consistency. The words "log out" are separated in the same sentence; "log in" appears as such elsewhere when used as a verb in user.module.
(2) "Login" is arguably not in use as a verb. I understand that language evolves, especially technical language, but my opinion is that "login" is only in common use as a noun (e.g., "what's your login?").

Note: This text does not currently exist in D7, which is why the issue is on D6.

CommentFileSizeAuthor
#18 546356revised.patch11 KBjhodgdon
#12 546356withtest.patch10.66 KBjhodgdon
#5 546356.patch9.94 KBjhodgdon
change_login_to_log_in.patch3.36 KBthreexk

Comments

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

That is correct; "login" is a noun, while "log in" is a phrasal verb.
If I understand well, only critical bugs are fixed on Drupal 6 (and this doesn't seem critical).

threexk’s picture

threexk commented

I think bug fixes of any priority are still being accepted, just D6 is feature frozen so no new features are being accepted. 6.13 had grammar and documentation fixes: http://drupal.org/node/507568.

c960657’s picture

c960657 commented
Version: 6.x-dev » 7.x-dev
Component: user.module » user interface text
Status: Needs review » Needs work

D7 still uses the "login" as a verb, e.g. in comment.module. Let's fix all modules in HEAD in one patch (it's not too many places). Then we might consider fixing D6 afterwards.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Priority: Minor » Normal

This definitely needs to be fixed, and it isn't exactly minor really, since our doc standards require log in as the verb. See http://drupal.org/node/338208

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new 546356.patch9.94 KB

Here's a patch. I grepped the source code for all uses of 'login', and fixed the ones I felt were verbs.

It's possible this will break some tests if they were looking for text "login" on a screen, but let's see what the test bot says...

aspilicious’s picture

aspilicious commented

I reviewed the corrected sentences (even the which <-> that thingie) and it looks ok

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

Oh yeah, I was going to mention the which->that thing. Pet peeve left over from obsessive boss some 15+ years ago to get the usage right on which/that, so if I happen to notice it, I can't help fixing it...

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

Just as a note on #2, I think most of the grammar/doc fixes in Drupal 6 were in API documentation, not in UI text. The difference is that UI text has to get translated, so if it changes in Drupal 6, all the translations break. So changes to user interface text are not taken lightly in D6.

Status: Needs review » Needs work

The last submitted patch, 546356.patch, failed testing.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Title: Change "login" verb to "log in" in Users help » Change "login" verb to "log in" in user interface
Status: Needs work » Needs review
jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Needs work

It looks like I need to update a test as well.. investigating...

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new 546356withtest.patch10.66 KB

Here's a patch that also updates the test's text to "log in" in one place. Tests should pass this time, hopefully!

threexk’s picture

threexk commented

Just as a note on #2, I think most of the grammar/doc fixes in Drupal 6 were in API documentation, not in UI text. The difference is that UI text has to get translated, so if it changes in Drupal 6, all the translations break. So changes to user interface text are not taken lightly in D6.

That is a good point, unfortunately. Better to not make them in D6 then. This makes me want to scrutinize D7 to make sure there aren't any other grammatical problems, so they don't live forever.

Thanks for putting the patch together. I reviewed it by hand and all the changes look correct. Also, I grepped and noticed a lot of tests use "Login" as a verb in their comments. I guess you don't care about these since they aren't UI?

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

I reviewed all of the files in core for "login" except *.test... we could fix those comments, but I'm inclined not to right now.
more important to get the UI right at this moment, with UI text deadline coming.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

So can we mark this RTBC?

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Reviewed & tested by the community

Works nicely.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Needs work

At the beginning of the first hunk:

"This site supports OpenID, a secure way to log into many websites ..."

I'm pretty sure "log into" should be "log in to" (at least Wikipedia agrees with me).

I would just make this change myself, but unfortunately this no longer applies after a bunch of the other fixes that went in today.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new 546356revised.patch11 KB

Good catch. Here's a reroll with that change and updating the ftp hunk that wouldn't apply.

Status: Needs review » Needs work

The last submitted patch, 546356revised.patch, failed testing.

Status: Needs work » Needs review

Re-test of 546356revised.patch from comment #18 was requested by aspilicious.

aspilicious’s picture

aspilicious commented

Trust me...
This will work...

After 2 weeks i know the testbot...

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Setting back to RTBC since it was RTBC before and now the test bot is happy.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed to HEAD. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.