Closed (fixed)
Project:
FeedAPI
Version:
6.x-1.x-dev
Component:
Code feedapi_node
Priority:
Critical
Category:
Task
Assigned:
Reporter:
Created:
11 Aug 2009 at 06:51 UTC
Updated:
2 Oct 2009 at 07:40 UTC
Jump to comment: Most recent file
While the automated tests, it's not really valid to call module_invoke() because it may call such modules that are not enabled inside the test sandbox.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | 545698-5_remove_module_invoke_test.patch | 3.57 KB | aron novak |
| #1 | 545698_remove_module_invoke_test.patch | 3.42 KB | aron novak |
Comments
Comment #1
aron novakTests are passed, a new approach is used in testKeepNodeSettingsAtUpdate().
Comment #2
alex_b commented"module_invoke() because it may call such modules that are not enabled inside the test sandbox"
I don't see how this could happen - what am I missing here?
What did you replace module_invoke() with?
Comment #3
aron novak#2: module_ivoke uses that the Drupal instance of the live site. Normally when use use simplepie's browser, it uses another virtual Drupal instances. This is really possible that you have a lot of modules enabled in your live site, but in the virtual Drupal, simpletest only installs and enables those modules what are you specify in setUp().
I replaced that function call with a self-modifying RSS feed :) This is hosted externally, just as the other test feeds.
Comment #4
aron novakThis is such a patch what I would like to see in FeedAPI 1.9.
Comment #5
aron novakI rerolled this patch after #499680: Restructure tests
Comment #6
alex_b commentedRTBC
Comment #7
aron novakcommitted