de-op hook_node_type() [#545306]

http://api.drupal.org/api/function/hook_node_type/7 needs to be split into hook_node_type_insert() hook_node_type_update() and hook_node_type_delete()

To do this, first find any hook implementations in core and change them too hook_node_type_$op($argument) instead of hook_node_type($op, $argument);, then do the same for hook documentation, and any tests which might implement the hook. Once that's done, you'll need to update modules/node/content_types.inc to change the module_invoke_all() calls to the correct hook and arguments. Tagging as novice but that shouldn't stop someone else taking this on if they want to clean up - we really need to remove $op from any remaining hooks before freeze.

Comment	File	Size	Author
#2	545306-hook_node_type_op.patch	10.84 KB	alexanderpas
#2

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

alexanderpas CreditAttribution: alexanderpas commented 10 August 2009 at 23:05

subscribing

Comment #2

alexanderpas CreditAttribution: alexanderpas commented 11 August 2009 at 00:19

Assigned:	Unassigned	» alexanderpas
Status:	Active	» Needs review

File	Size
545306-hook_node_type_op.patch	10.84 KB

first patch...

Comment #3

Dries CreditAttribution: Dries commented 11 August 2009 at 12:11

Interesting patch (I like), but no tests that need to be updated?

Comment #4

alexanderpas CreditAttribution: alexanderpas commented 11 August 2009 at 12:47

nope, no tests needed updating... however, i think this is being tested by other code that doesn't call it explicitly.

Comment #5

Dries CreditAttribution: Dries commented 11 August 2009 at 14:15

Status:

Needs review

» Reviewed & tested by the community

This looks good to me, so marking it as RTBC.

Comment #6

webchick

she/they

English

Vancouver 🇨🇦

CreditAttribution: webchick commented 11 August 2009 at 15:51

Status:	Reviewed & tested by the community	» Needs work
Issue tags:		+Needs documentation

Oh, yes please! :D

Committed to HEAD.

Needs to be documented in the upgrade docs.

Comment #7

dropcube CreditAttribution: dropcube commented 11 August 2009 at 19:15

For reference, other hook that needs removing of $op is hook_filter, see #546336: hook_filter_info(): Remove $op from hook_filter()

Comment #8

emmajane CreditAttribution: emmajane commented 12 August 2009 at 00:40

Documentation update:

I've added a draft for the module upgrade text to http://drupal.org/node/546634
Please edit that page and leave a comment here to say if (1) more work is needed or (2) the text is fine as written. Once that text is correct I will incorporate it into the main D6->D7 upgrade page.