This is just a placeholder issue for now where I can note sort of odd things that happen when using the "Create commit message" feature, in the hopes that we can distill from that some tweaks to make the algorithm a bit smarter.

Comments

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

#536960: "Add content" link in Seven theme generates a commit message of:

"#536960 by Gábor Hojtsy, Bojhan, Stefan Nagtegaal, yoroy, webchick: "Add content" link in Seven theme."

Of those, really the only person that deserves credit on commit is Gábor Hojtsy.

IMO, we should actually probably remove the "and other people who were active in the issue" from the algorithm for now, to keep it simple, and only pull names from people with .diff/.patch uploads. It's pretty trivial when scanning an issue for the last time to get the names of the reviewers who made substantial contributions.

OTOH, if we want to keep that part, perhaps we need to scale it arithmetically, so that we find the N contributors with patches attached, N needs to be > 5 or something before we start taking into account others, and we'll only choose some portion of them (like 1/5 of the most active responders). Eh. Not sure. I think it needs more thought though so we should likely remove that part for now.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

Actually, the current algorithm (which made me go nuts for a few hours) is:

- Get all patch submitters
- Get all commenters

- Sort both lists separately by the amount of occurrences

- From all patch submitters, take the first/top 3
- Walk through the list of commenters, skip names in the top 3 submitters, and append top commenters until the resulting list reaches 6 names.

uhm, crazy. Did I really do that? :P

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Active » Fixed

Thanks for reporting, reviewing, and testing! Committed http://drupal.org/cvs?commit=248118

Let's go with that for now and observe whether it works. Feel free to re-open this issue.

#543178 by webchick, sun: Tweak commit message algorithm.

I should have used that!!! ;)

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

The new is:

- Get all patch submitters
- Get all commenters

- Sort both lists separately by the amount of occurrences

- Add all patch submitters
- Append a number of top commenters (10% of all issue follow-ups) [which can also mean 0 for issues with < 10 total follow-ups]

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

Additionally, the idea was to rather get a longer list than a shorter to save us from typing/copying usernames manually.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.