Watchdog not logging update errors

The error reporting has nothing to do with ajax... outputting errors during the updating is bad whether JS is used or not. With the non-JS version, any extra output such as error messages only appears for a second anyway.

The real issue is that some or all errors are not being logged to the watchdog correctly.

could someone elaborate where the watchdog call is missing? error_handler() is not behaving properly. i will do whatever needs to be done if i get some guidance here.

This patch removes the last shreds of configuration dependency of update.php, and improves the handling of fatal errors. The main issue was that PHP does not pass most fatal errors through the custom error handler, so they were never logged in the watchdog. So I changed things around (again).

• The PHP error printing is turned off only until Drupal's error handler is installed. This means that the unavoidable database errors which are dealt with in update_fix_xxxxx() are still silent. But later fatal errors are reported on screen.
• Instead of redirecting to the summary page when a fatal error occurs during updating, we give the user a chance to copy/paste the error message. The output buffering trick is used to provide a friendly error page for fatal errors, even for the non-JS version (image).
• On the summary page, the user is told exactly which update failed as well as any other non-fatal warnings that occurred before the fatal error (image).

Note that fatal errors are only those that cause PHP to stop directly (parse error, non-existant function, memory/time limit, ...). These are mostly development mistakes. The vast majority of users will only encounter warnings (e.g. failed db queries) which were dealt with elegantly already.

-

WFM. This seems to fix all the issues.

As a side note, the problem many of us had with watchdog not storing our errors wasn't entirely due to php not passing errors through the error handler. You will find that devel.module reverts drupals error_handler back to the default(look at devel_init). This is a quick debug feature when working on pages but is going to be undesirable on any ajax callback. This is what was probably the cause of the problem annoying Dries in the first place unless he was having a parsing error.

I can only admire what Steven is cooking.

Seems to work fine, waiting for word from Neil.

FWIW I think Neil is out till Wednesday unless someone has a more direct line to him.

Works perfectly for me! :-)

applied