Hi,

I am getting the following once I get to the page that asks me to enter the attendee email addresses:

DEFAULT: Test Paid Event - <span class="date-display-single">August 29, 2009 - <span class="date-display-start">12:30pm</span><span class="date-display-separator"> - </span><span class="date-display-end">5:30pm</span></span>

All the html is printed in the title. My fix was to simple add a strip_tags() to uc_signup_attendees_form_emails():

      '#title' => check_plain($node->title) .' - '. strip_tags($date_formatted),
CommentFileSizeAuthor
#8 uc_signup.patch1.03 KBjacerider
#6 uc_signup.patch1.25 KBjacerider
#5 Picture 1.png45.45 KBjacerider
#3 uc_signup.patch985 bytesjacerider

Comments

ezra-g’s picture

ezra-g commented
Status: Active » Postponed (maintainer needs more info)

Can you clarify what you mean by "getting the following" -- Where do you see this markup?

Also, it would be easier to evaluate your proposed change if you offer a patch.

Thanks!

jacerider’s picture

jacerider commented

Sorry bud,

When I add a signup enabled product to the cart, and go to checkout, I am taking here:

uc_signup/attendees

On that page, the following type is displayed:

Please enter the email address of each attendeee for this event. If an attendee does not have an account on this site, you'll be prompted to enter some information about that attendee.

(Looks like we have a spelling error in there as well -- I'll add that to my patch)

And then, in the fieldset just below that, there is a title. My title has the HTML code displayed. Look for my patch in just a few moments.

jacerider’s picture

jacerider commented
StatusFileSize
new uc_signup.patch985 bytes

Here is the patch.

ezra-g’s picture

ezra-g commented
Title: HTML in title » HTML in Event Fieldset Title
Status: Postponed (maintainer needs more info) » Needs work

Hmm, I wasn't having this problem and applying your patch actually *caused* me to see similar markup in the fieldset title.

With my date field configuration, which seems pretty standard, $date_formatted unescaped is:

Fri, 02/12/2010 - 03:06

Adding check_plain causes this markup to display in the rendered page. Without this patch, I tried generating the error with multiple date values and different date formatters but wasn't successful.

Thanks for finding the "attendeees" typo! I'll wait until we resolve this issue to commit a fix for that.

Setting status to "needs work".

jacerider’s picture

jacerider commented
StatusFileSize
new Picture 1.png45.45 KB

Here is a ss of what things look like for me. I will see what else I can do here...

jacerider’s picture

jacerider commented
StatusFileSize
new uc_signup.patch1.25 KB

I see what I did. I made the correct change, then redid it to create the patch, and did it wrong.

I have attached the new patch.

ezra-g’s picture

ezra-g commented
Status: Needs work » Needs review

Ah -- strip_tags seems like a good solution here. Marking as needs review, which I can likely do later today.

jacerider’s picture

jacerider commented
StatusFileSize
new uc_signup.patch1.03 KB

Wow, I'm on a roll. HERE is the correct patch. It's too early to be doing this stuff. :)

I added a t() that didn't need to be in there on the previous one.

ezra-g’s picture

ezra-g commented
Status: Needs review » Fixed

This is committed. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.