The module's code doesn't follow Drupal's coding standards. It would be nice to update this first, before committing any new code.

CommentFileSizeAuthor
#1 537174-Paycom-whitespace.patch40.04 KBkscheirer

Comments

kscheirer’s picture

Status: Active » Needs review
StatusFileSize
new40.04 KB

Updated as per http://drupal.org/coding-standards and Coder module review.

No functional changes are included, just whitespace, and removing some debug comments.

hypertext200’s picture

Status: Needs review » Patch (to be ported)

Thanks for the patches, i'm looking forward for commit those to CVS

senpai’s picture

Status: Patch (to be ported) » Needs review

I don't think you mean 'patch: to be ported'. That status is reserved for patches that have already been committed to the newest branch of the project (commonly called 'head') and now need to be *ported* to a previous version as well.

Here's how to do it. In these issue queues, patches that are not yet committed to your project should be left at the 'needs review' state so that they may be reviewed, commented upon, or tested by others.

Since you are the owner of this module, you may commit these patches yourself. You do not necessarily *need* to wait for a review. :) Once a patch has been committed, you should mark the issue queue as 'fixed'.

Make sense?