Clicking Save & Edit on a Webform causes issues [#536244]

When clicking Save & Edit on a Webform, the following fields have their radio selections changed to 'Custom' (from default) and cause subsequent saves to fail: -

E-mail from name, E-mail from name and E-mail subject.

Steps to re-produce: -

1. Create a new Webform (any content will do as long as it passes the required validation).
2. Ensure E-mail from name is set to 'Custom' (and has some email address set) and E-mail from name and E-mail subject are set to 'Default'.
3. Click 'Save'.
4. Click 'Edit'.
5. Click 'Save & Edit' and you'll find the Webform has saved, but if you click 'Save & Edit' again you'll notice it's messed with the Email radio options (and fails the validation).

Comments

Comment #1

himerus CreditAttribution: himerus commented 31 July 2009 at 16:37

Assigned:

Unassigned

» himerus

Interesting, this is the type of testing that I have yet to really dig into, using webform & ubercart & other advanced node types.

I'll take a look @ this as soon as I can, and attempt to duplicate the issue, and see where the problem is coming from.

Comment #2

asha79 CreditAttribution: asha79 commented 1 August 2009 at 02:25

Thanks :) I should have mentioned also that I love the extension and fine it extremely useful! I'll see if what I can find too..

Comment #3

pribeh CreditAttribution: pribeh commented 4 January 2010 at 22:25

I'm getting several users reporting, and I've observed this myself, a validation error saving nodes (such as blog) with a simple taxonomy, CCK imagefield and creative commons license. My difficulty is that I can't tell if it's one of these fields not getting validated that's the issue. My debugging skills need improvement. It seems to only happen once and awhile and only after having saved the node once already. Any chance you might be able to look at my site? It's open to the public.

www.londonfuse.ca

Should be a demo demo account but if not just make one.

Thanks for making this module. It works amazingly well.

Comment #4

techpop CreditAttribution: techpop commented 6 April 2010 at 09:34

This is an issue within webform in the 6.x-2.9 release. I believe this issue is fixed in the 6.x-3.0-beta4 release. So your choices are to either upgrade to the new unstable version, or you can modify a line in the webform.module file.

If you want to modify the webform code, you'll need to change out line 770:

'#default_value' => is_numeric($node->webform['email_'. $field]) ? 'component' : ((empty($default_value) || ($node->webform['email_'. $field] != 'default' && isset($node->webform['email_'. $field]))) ? 'custom' : 'default'),

to:

'#default_value' => is_numeric($node->webform['email_'. $field]) ? 'component' : ((empty($default_value) || ($node->webform['email_'. $field] != 'default' && !empty($node->webform['email_'. $field]))) ? 'custom' : 'default'),