Using checkboxes instead of radio buttons will save you a bunch of code. Enabled and disabled radio buttons are kind of silly. Just use a checkbox for toggled settings ;-) .

Absolutely critical! :-P

CommentFileSizeAuthor
booleans_are_awesome_to_the_max.patch2.38 KBrobloach

Comments

naheemsays’s picture

naheemsays commented
Status: Needs review » Reviewed & tested by the community

This looks good to go - tested and it works and the code changes look good. I especially like that there are more lines with a "-" then with a "+"

litwol’s picture

litwol commented
Status: Reviewed & tested by the community » Needs review

This needs one last test and that is: How does this preserve old user settings ?

naheemsays’s picture

naheemsays commented

AFAIK it does preserve them as there should be no functional change except for the use of a checkbox instead of radios to the end user.

naheemsays’s picture

naheemsays commented
Status: Needs review » Reviewed & tested by the community

There is no functional change from old settings - just a visual one.

litwol’s picture

litwol commented
Status: Reviewed & tested by the community » Fixed

Cheers

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.