We have comments enabled on all of the content types on our site. All content types are being displayed through Panels 6.x-3.0-rc1. We installed Nodecomment 6.x-2.x-dev today and all of our Panels node overrides stopped working (instead the site just shows the default system node view page).

Disabling Node Comments seems to fix it. I thought at first it might be just pages that have comments showing as well, but I've confirmed that this happens when comments are not included in the page through Panels.

Not sure if this is a panels or a node comment bug.

Comments

friolator’s picture

friolator commented
Project: Node Comments » Chaos Tool Suite (ctools)
Version: 6.x-2.x-dev » 6.x-1.0-rc1

I'm moving this over to Ctools, after reading the Panels issue linked below. I think I'm finally getting my head wrapped around what's handling what when ;-)

I'm wondering if it's related:

http://drupal.org/node/529182#comment-1849106 ...I ran the same query but on node/%:

SELECT page_callback FROM menu_router WHERE path = 'node/%';

With Node Comment enabled, the query returns:
nodecomment_node_view

With Node Comment disabled, the query returns:
page_manager_node_view

merlinofchaos’s picture

merlinofchaos commented

Are you sure you're running the latest nodecomment 2.x dev?

function nodecomment_menu_alter(&$items) {
  // Override the node view handler for our purpose.
  if (!module_exists('delegator') && !module_exists('page_manager') && $items['node/%node']['page callback'] == 'node_page_view') {
    $items['node/%node']['page callback'] = 'nodecomment_node_view';
  }

There's no way nodecomment can be stealing the menu item away from page manager if you're up to date.

friolator’s picture

friolator commented

hmm. I downloaded it last week from here: http://drupal.org/node/472876 -- that's the one at the top of the list of all releases. The $Id at the top of nodecomment.module reads:

// $Id: nodecomment.module,v 1.3.2.15.2.17.2.35 2009/06/23 22:52:19 merlinofchaos Exp $

but nodecomment_menu_alter() doesn't match what you posted:

<?php
function nodecomment_menu_alter(&$items) {
  // Override the node view handler for our purpose.
  if (!module_exists('delegator') && $items['node/%node']['page callback'] == 'node_page_view') {
    $items['node/%node']['page callback'] = 'nodecomment_node_view';
  }
?>
friolator’s picture

friolator commented

By the way, I just dropped in <?php && !module_exists('page_manager') ?> where it was missing and it seems to have fixed my problem. But if there were other changes and there's a newer version I should be using, please let me know where I can grab it!

Thanks!

merlinofchaos’s picture

merlinofchaos commented
Project: Chaos Tool Suite (ctools) » Node Comments
Version: 6.x-1.0-rc1 » 6.x-2.x-dev
Status: Active » Fixed

...apparently I did not commit that change to nodecomment module. Except I remember doing that. Sigh. Whatever happened. Sorry about that, it's committed now. The next rebuild will be at midnight, GMT I believe.

friolator’s picture

friolator commented

awesome. thanks!

vood002’s picture

vood002 commented

I have no idea what I'm missing here...I have node comments working nicely around the site, and I just installed Page Manager to install some panel pages. I haven't played around with anything past panels 2 so this is all unfamiliar territory to me, and I'm not planning on processing my nodes with page manager.

Upon installing Page Manager all of my node comments stopped working. I found this thread and was able to get them to work by commenting out the check you're talking about here...ie:

function nodecomment_menu_alter(&$items) {
  // Override the node view handler for our purpose.
	/*
  if (!module_exists('delegator') && !module_exists('page_manager') && $items['node/%node']['page callback'] == 'node_page_view') {
    $items['node/%node']['page callback'] = 'nodecomment_node_view';
  }
	*/

I'll just go forward like this for now...until i find myself in a position where I need to use page manager more than I currently do.

Is this a bug?

EDIT

My mistake...it wasn't commenting out that code that worked, I simply had to enable the node_view system page in page manager. Still seems like a bug to me...or perhaps something that should be mentioned in documentation.

merlinofchaos’s picture

merlinofchaos commented

Be sure you have the most recent dev. The last commit i made fixed this.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.