I started using this module on a new site after using ecommerce and its worldpay module (thanks Dublin Drupaller) on some older sites which had some features I liked so I've created a patch to port them over.
This is a somewhat duplicate of:
http://drupal.org/node/369096
http://drupal.org/node/515546
This patch adds the following fields to worldpay settings form:
- Worldpay MD5 secret - so that you can secure your transactions and prevent tampering
- Worldpay number of minutes valid - so that you can limit the amount of time a user has to complete their transaction on the worldpay server
The patch passes a new variable to worldpay called MC_callback which is the worldpay completion url. If you set your callback to <wpdisplay item=MC_callback> in your worldpay account setting (on the worldpay site) it allows you to use one worldpay account for several sites.
The patch removes switch as this card type no longer exists.
The patch requires the download of the new logo (avaliable here http://www.rbsworldpay.com/images/cardlogos/poweredByRBSWorldPay.gif) and to put this in the images directory.
The patch also theme's the completion page using the site's theme.
All comments on the patch welcome! I have tested this on my own site and it's working.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | uc_worldpay-md5-529760.patch | 1.71 KB | matason |
| #2 | uc_worldpay-529760.patch | 6.48 KB | alexpott |
| uc_worldpay.patch | 12.4 KB | alexpott |
Comments
Comment #1
matason commentedalexpott, I've updated the logo - http://drupal.org/cvs?commit=281086
I'll take a proper look at your patch asap.
Comment #2
alexpottmatason, I've updated the patch to only do the necessary and to work against the HEAD version of uc_worldpay and I've changed this issue title to reflect that.
On my live site I've found it useful if the order status is updated to canceled if the user presses the cancel button on the worldpay screens so I've added the one line for that functionality.
Plus just to let you know, the latest nightly build is not available on the project page and in cvs the Drupal-6--1 branch doesn't seem to have the latest code...
Comment #3
matason commentedI've attached a patch based on @alexpott's code, it's against HEAD/RC1 and adds support for md5 - I've not been able to test this so would appreciate any feedback.
Let's look at the other items raised here and open separate issues for each if still required.
Once again, big thank you to @alexpott!
Comment #4
gruberroland commentedThanks a lot for your patch. The latest D6 release and the D7 development branch now have MD5 support.
Comment #5
thoughtcat commentedHi
I've had some fraudulent transactions on my site recently and contacted WorldPay who have replied with some info about using MD5 security. It seems from this thread that this has long been incorporated into this module, but I don't see how. I have Worldpay 6.x-1.0-rc1 installed on my site. The original post above says:
If I go to /admin/store/settings/payment/edit/methods and expand "RBS WorldPay settings" I don't see any fields for "MD5 secret" or "number of minutes valid". Am I looking in the wrong place or do I need to tick a box somewhere?
Thanks
Comment #6
thoughtcat commentedComment #7
gruberroland commentedMD5 is only available for Drupal 7.
Comment #8
thoughtcat commentedYou said in #4 "The latest D6 release and the D7 development branch now have MD5 support."