After checking out this tiny module (thanks for this nifty one!) i emptied field for memory in settings. I expected it to fall back to default value given by settings.php, .htaccess, php.ini, etc. It crashed and i had to remove the module from system table in database by hand.

Comments

kenorb’s picture

kenorb CreditAttribution: kenorb commented

Thanks, I'll add validation to not allow empty values.
Normally ini_set() shouldn't allow to set any invalid option that could make a website crash.
Thanks for reporting it and sorry for any inconvenience. I haven't got time to test it correctly.
I'll investigate that tomorrow and I'll fix that as soon as possible.

To reset to default, probably option 'Reset to defaults' should works. But I'll test it as well.

rokr’s picture

rokr CreditAttribution: rokr commented

At least there could be a big warning to not lower the value below a given value. :)

cheers, Ronald

kenorb’s picture

kenorb CreditAttribution: kenorb commented
Status: Active » Fixed

Fixed:
http://drupal.org/cvs?commit=242396

Defined that user can't set lower memory than: 16M
And can't set lower execution time than 30 sec

Added as well couple of tweaks for Filter and Views module.

In case of emergency, those sql queries should help:

DELETE FROM variable WHERE name LIKE 'drupal_tweaks_php_%';
DELETE FROM cache WHERE cid = 'variables';

Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.