It doesn't really make sense in many cases to re-run the tagging when submitting an UPDATE, so maybe an option to control which events would trigger a submission?

CommentFileSizeAuthor
#3 autotagging-n527750.patch5.48 KBdamienmckenna

Comments

IncrediblyKenzi’s picture

IncrediblyKenzi commented

This is by design.. There's no simplistic way of determining if the node's content changed; as a result we re-process the node to fetch tags.

I don't want to close this outright without your feedback, but as it stands I'm not convinced it incurs significant overhead by forcing a tag update on update as well as insert.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

The issue is control - content editors may not wish to resubmit the node. In effect, currently there's no way to remove a term that gets added, as each time it'll be re-submitted and the terms added again.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Needs review
StatusFileSize
new autotagging-n527750.patch5.48 KB

Here's an initial patch. Note: it moves the guts of the nodeapi hook into a separate file.

IncrediblyKenzi’s picture

IncrediblyKenzi commented
Status: Needs review » Needs work

I think this should probably be a bitmask.. There are a couple of other options that could be included:

1. apply autotagging on insert
2. apply autotagging on update
3. apply autotagging on both
4. ask user on update to apply autotagging
5. ask user on insert to apply autotagging

Good start however.

Archnemysis’s picture

Archnemysis commented

Subscribing. Would certainly appreciate this feature request.