Three bugs with "Add new comment" link when comment form is set to "display on separate page" [#517988]

The following two bugs can be observed when Talk is enabled and the comment form is set to "display on separate page."

Bug #1: The "Add new comment" link no longer includes the #comment-form anchor. For example, with Talk disabled, it links to:

http://example.com/comment/reply/122#comment-form

When Talk is enabled, the link is changed to this in all cases:

http://example.com/comment/reply/122

Bug #2: The "Add new comment" link is added to the teaser's $links. Drupal's default because is to exclude this link from the teaser's $links.

Comment	File	Size	Author
#4	talk_link_fixes.patch	4.04 KB	todd nienkerk
#1	talk_module_comment_form_errors.png	48.62 KB	todd nienkerk

Comments

Comment #1

todd nienkerk commented 13 July 2009 at 17:21

Title:

Two bugs with "Add new comment" link when comment form is set to "display on separate page"

» Three bugs with "Add new comment" link when comment form is set to "display on separate page"

Status	File	Size
new	talk_module_comment_form_errors.png	48.62 KB

Found another bug:

Bug #3: The following warnings appear when visiting the add comment page/form (when Talk is enabled and the comment form is set to "display on separate page"):

    * warning: Illegal offset type in isset or empty in /test-site/includes/path.inc on line 65.
    * warning: Illegal offset type in /test-site/includes/path.inc on line 70.
    * warning: preg_match() expects parameter 2 to be string, array given in /test-site/includes/bootstrap.inc on line 771.

I have attached a screenshot.

Comment #2

todd nienkerk commented 13 July 2009 at 17:37

These bugs are related to #506670: Module removes "X new comments" link in node links.

Additionally, changing the hook_link()'s keys from comment_* to talk_* fixes bug #3 above. I suspect a proper implementation of hook_link_alter() would solve most or all of these bugs.