There needs to be a way to delete custom subscriptions. I'll try to take care of this if and when I get some free time, but it might not be for a few days.

CommentFileSizeAuthor
#5 notifications_custom_patch1.txt822 bytesstmind
#3 notifications_extra-514082-3.patch830 bytesdanepowell

Comments

roball’s picture

roball commented

+1

Just like the "Add subscription for selected users" Update option on admin/user/user, there should also be something like "Remove subscription for selected users".

danepowell’s picture

danepowell commented

If it wasn't clear by now, I in fact do not have the time to take care of this, so don't wait on me :)

danepowell’s picture

danepowell commented
Status: Active » Needs review
StatusFileSize
new notifications_extra-514082-3.patch830 bytes

Actually, the code for this already seems to exist or was added since this issue was created. There was just a conditional keeping it from showing up in the UI. I can't tell what the purpose of the conditional was, so I removed it. If no one objects to this, I'll commit the changes in a few days/weeks.

roball’s picture

roball commented
Status: Needs review » Reviewed & tested by the community

Patch works - now at admin/messaging/customsubs/csid/[CSID]/edit there is also a [ Delete ] button (in addition to the buttons [ Save ] and [ Reset to defaults ]).

However, the [ Delete ] and [ Reset to defaults ] buttons also appear at admin/messaging/customsubs/new, where only the [ Save ] button should be.

stmind’s picture

stmind commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new notifications_custom_patch1.txt822 bytes

Hi,

The actual problem was just that the logic of the conditional Dane mentioned was reversed. The "Delete" button was showing on the "new" form, and the "Reset to defaults" was showing on the "edit" form. Reversing the if/else block solves the problem and subscriptions can be deleted.

Updated patch attached. Would appreciate someone's test.

eft’s picture

eft commented

this patch worked for me - thanks

danepowell’s picture

danepowell commented
Status: Needs review » Fixed
roball’s picture

roball commented

Can confirm that Notifications Add-ons 6.x-2.x-dev (2010-Feb-02) works fine on this.

At admin/messaging/customsubs/csid/[CSID]/edit there are now the buttons [ Save ] and [ Delete ], and at admin/messaging/customsubs/new there are the buttons [ Save ] and [ Reset to defaults ].

Thanks for fixing this!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.