This cleans up the comment settings form so it fits on one page.

Additionally collapsed comments are removed entirely.

collapsed comments are so 2001!

CommentFileSizeAuthor
#26 comment-wrapper-cleanup.patch908 byteskika
#21 comment_settings.patch24.51 KBcatch
#19 comment_settings.patch22.6 KBcatch
#15 comment_settings.png21.12 KBcatch
#15 comment_settings.patch19.27 KBcatch
#14 comment_settings.patch19.39 KBcatch
#12 comment_settings.patch18.65 KBcatch
#12 comment_contact.png19.93 KBcatch
#7 comment_settings.patch16.17 KBcatch
#6 comment_settings.png21.59 KBcatch
#6 comment_settings.patch14.29 KBcatch
#4 settings_with_anon.png23.73 KBcatch
#2 comment_settings.png20.29 KBcatch
#2 comment_settings.patch13.57 KBcatch
#1 comment_settings.patch13.47 KBcatch
comment_settings_after.png448.36 KBcatch
comment_settings_before.png487.01 KBcatch
comment_settings.patch13.56 KBcatch
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
FileSize
comment_settings.patch13.47 KB

Removed some descriptions.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
FileSize
comment_settings.patch13.57 KB
comment_settings.png20.29 KB

Bit more form cleanup, new screenshot.

Bojhan’s picture

Bojhan CreditAttribution: Bojhan commented

Putting them inline, so I can comment.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
FileSize
settings_with_anon.png23.73 KB

When anonymous users have access to post comments:

Without the anonymous settings:

Bojhan’s picture

Bojhan CreditAttribution: Bojhan commented

I think this is a really good cleanup, we could probally refine it a bit more. Almost looks like some functionality disappeared.

Do we need to mention that administer comments permission is able to override it? Not sure if Administrators will look here, to find that out - when it happens. (Not sure if it even causes confusion at their end)

Allow separate subjects when entering comments - not sure what is meant by separate here.

Quick reply form below comments - Can we reprhase this? Allow quick replying on comments? I like us to say we give the funcionality, without mentioning that an "form" is placed.

Also, I think Require preview should be the last option + unchecked by default.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
FileSize
comment_settings.patch14.29 KB
comment_settings.png21.59 KB

Went through some of these with Bojhan, here's an updated patch.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
FileSize
comment_settings.patch16.17 KB

Default the comment form to show below comments, I hate having to set this every time I install Drupal.

kika’s picture

kika CreditAttribution: kika commented

While we are at it:

 t('Anonymous commenting'),

t('Anonymous posters may not enter their contact information'),
t('Anonymous posters may leave their contact information'),
t('Anonymous posters must leave their contact information')),

are too long and mentally hard to parse and distinguish. Any suggestions to simplify those?

dmitrig01’s picture

dmitrig01 CreditAttribution: dmitrig01 commented

Quick Reply Form is somewhat vague. If i hadn't previoulsy read the issue i would have no idea what it meant.

Bojhan’s picture

Bojhan CreditAttribution: Bojhan commented

So, lets take a crack at those - lets step back and see the order.

Not allowed,
Allowed,
Required

So first of all it should be

Allowed,
Not allowed,
Required

Than what is confusing is they start with the same two words, but the distinction is only on the two following. Hmm, I dont have any suggestions to this yet.

Status: Needs review » Needs work

The last submitted patch failed testing.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Needs work » Needs review
FileSize
comment_contact.png19.93 KB
comment_settings.patch18.65 KB

I think quick reply is pretty standard now with gmail and others.

Had a crack at anonymous comments.

+        COMMENT_ANONYMOUS_MAY_CONTACT => t('Collect contact information'),
+        COMMENT_ANONYMOUS_MAYNOT_CONTACT => t('Do not collect contact information'),
+        COMMENT_ANONYMOUS_MUST_CONTACT => t('Require contact information')),

Status: Needs review » Needs work

The last submitted patch failed testing.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Needs work » Needs review
FileSize
comment_settings.patch19.39 KB

Fixed up the tests.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
FileSize
comment_settings.patch19.27 KB
comment_settings.png21.12 KB

Put anonymous contact settings back how they were - let's do that in a followup patch - I don't have good ideas, and Bojhan reckoned the change was worse than the old text.

This also changes 'quick reply' to the less cryptic 'Show comment form on the same page as comments'.

Status: Needs review » Needs work

The last submitted patch failed testing.

yoroy’s picture

yoroy CreditAttribution: yoroy commented
Status: Needs work » Needs review

Looking at the screenshot, all settings make sense and seem understandable to me (quick replies was the one I had difficulty understanding).
RTBC from a UI/UX perspective me thinks.

Dries’s picture

Dries CreditAttribution: Dries commented

Everything looks good, except that the test fails.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
FileSize
comment_settings.patch22.6 KB

The new streamlined simpletest interface is great until you fix one test by breaking another. All comment tests should pass with this one.

Status: Needs review » Needs work

The last submitted patch failed testing.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Needs work » Needs review
FileSize
comment_settings.patch24.51 KB

grr.

Bojhan’s picture

Bojhan CreditAttribution: Bojhan commented
Status: Needs review » Reviewed & tested by the community

#15 Looking at this, it looks RTBC to me. There are no improvements we can make from this point on, that should not live in its own followup.

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

I'm cool with this. People that want collapsed comments, can use Javascript.

Committed to CVS HEAD. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

kika’s picture

kika CreditAttribution: kika commented
Status: Closed (fixed) » Active

There are still references to depreciated collapsed in modules/comment/comment-wrapper.tpl.php:

 * - $display_mode
 *   - COMMENT_MODE_FLAT_COLLAPSED
 *   - COMMENT_MODE_FLAT_EXPANDED
 *   - COMMENT_MODE_THREADED_COLLAPSED
 *   - COMMENT_MODE_THREADED_EXPANDED

should become

 * - $display_mode
 *   - COMMENT_MODE_FLAT
 *   - COMMENT_MODE_THREADED
kika’s picture

kika CreditAttribution: kika commented
Status: Active » Needs review
FileSize
comment-wrapper-cleanup.patch908 bytes

Here's the patch. I hope I got it in right format.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Quick fix

I was sure I grepped everything, but apparently missed these.

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

Status: Fixed » Closed (fixed)
Issue tags: -Quick fix, -Usability

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Quick fix, +Usability

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.