The recently committed hidden divs patch creates duplicate div IDs for the thumbnails, and removes the semantically useful

    container for the thumbnails. I agree that the PHP and JS code is cleaner, which is nice, but for me, it makes the module unusable. The markup no longer validates, has duplicate content, and I can no longer style the thumbnails as a positioned list. They no longer have their own container, so individual positioning becomes more difficult.

    Here's how I had been using it (client was loving it!):
    http://redesign.cmrussell.org/

    I updated this to see if AHAH support was added - now I'm looking for an alternative... Are you open to going back to the list if I can provide a clean patch that doesn't depend on settings?

CommentFileSizeAuthor
#4 views_cycle-cleaner_markup.patch3.9 KBcriznach

Comments

criznach’s picture

criznach commented

Sorry - filter ate my markup. Should have read:

removes the semantically useful <ul> container for the thumbnails.

Crell’s picture

Crell commented

The switch to hidden divs was necessary to better support Ajax paging, which was only barely functional before. If it's now buggy I am totally open to a patch to make it less buggy, but going back to the hacked-up mess with trying to regenerate Drupal.settings within an AHAH callback isn't a good idea.

criznach’s picture

criznach commented

I'm not suggesting going back to the settings method. And I'm not very experienced with how views style plugins work. But... Is there a way that we can add the thumbnail data just once at the end? Adding it to every slide is causing validation problems and bloats the markup.

And by ajax paging, do you mean ajax loading of the content? This is what I was looking for when I updated the module, but I still can't get it to work. Is there an example or some docs? If I could look at the ajax scenario you'd like to support, I might be able to work on it a bit.

Thanks!
Chris.

criznach’s picture

criznach commented
Status: Active » Needs review
StatusFileSize
new views_cycle-cleaner_markup.patch3.9 KB

Here's a patch that cleans up the markup by moving the thumb data into a single unordered list below the slides. This eliminates duplicate IDs and creates markup that's more meaningful if JS and CSS are disabled. This also enabled me to run multiple cycle views on a single page without ID clashes.

I changed a couple of class names for consistency also.

"views-cycle-first" is now "view-cycle-first"
"views-cycle-last" is now "view-cycle-last"

These match the style of "view-cycle-even" and "view-cycle-odd"

Tested in FF3, IE6, IE7, Safari 2.

eabrand’s picture

eabrand commented
Status: Needs review » Reviewed & tested by the community

works great for me!

Crell’s picture

Crell commented
Status: Reviewed & tested by the community » Fixed

I fixed the whitespace formatting a little and corrected a code comment. Otherwise looked good. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.