It's a standard feature, 99% of sites run it (those that don't use apache solr or xapian - most of which depend on search module anyway), so we should enable it by default.

CommentFileSizeAuthor
enable_search.patch662 bytescatch
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Damien Tournoud’s picture

Status: Needs review » Reviewed & tested by the community

I support that. We need to refactor the Search API to be able to switch more easily to solr or xapian, but that's another issue, one we can probably tackle in the timeframe we have.

Damien Tournoud’s picture

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Hm. I've committed this. But I'll strongly warn that unless there is follow-up work done, this is going to be every new user's first steps in Drupal:

Step 1: Create some content.
Step 2: Search for it.
Step 3: Post a support request on the forums, since the search didn't find anything.

Since there is no step 0: Set up cron.

If that continues to be the default UX, we'll have to back this out before code freeze.

webchick’s picture

Status: Fixed » Needs work

Wow. Who knew that such a sweet, harmless looking patch could cause a failure in our test suite? ;) http://testing.drupal.org/pifr/file/1/8853

I had to roll this back.

webchick’s picture

Status: Needs work » Fixed

Ok. Now that #504016: Remove stupid assertion is in, trying this patch again. May we all pray that testing bot has mercy on our soul. ;)

Status: Fixed » Closed (fixed)
Issue tags: -d7uxsprint

Automatically closed -- issue fixed for 2 weeks with no activity.