Move e-mail notify to edit profile page

Anyone know how to do this with hook_menu_alter?

I've actually been having troubles with this but I'll start over again sometime today. Probably best if I try to look and see how other modules do it.

My thoughts were to have it as a fieldset. The main reason being that the form is small, and doesn't really have a need for it's own tab. However if you make it a tab I believe there is a module users can use to make all children tabs of the edit tab combined. So a tab also might be a more flexible solution. onepageprofile might be the name of the module... not sure though.

Well I took a shot. I honestly have no idea what i'm doing, so I took the road most traveled and decided just to use the form as opposed to a tab. I just bought Pro Drupal Development second edition so I'm fairly new to doing stuff outside of themes. Maybe someone else could provide a patch, but I have taken some time to try and figure this out.

So far I think it works. I tested it out briefly and no issues came up. But the route I took was via hook_menu alter and hook_user... But I guess that in the pm_email_notify module you would no long need $items['messages/notify'], as the only purpose of using hook_menu_alter was to unset/remove the messages/notify page.

Heres a quick run down... As stated if this was an actual patch we wouldn't need hook_menu_alter... but here it is anyways.

/**
* Implementation of hook_menu_alter().
*/
function mymodule_menu_alter(&$items) {
unset($items['messages/notify']);
$items['messages/notify']['access callback'] = FALSE;
}

And then we add the hook_user function to provide the form on the edit settings page.

/**
 *  Implementation of hook_user()
 */
 function mymodule_user($op, &$edit, &$user, $category = NULL) {
   switch ($op) {
    case 'form':
 if ($category == 'account') {
   global $user;
  $form['enable_pm_mail'] = array(
    '#type' => 'fieldset',
    '#title' => t('Privatemsg e-mail notification'),
    '#collapsible' => TRUE,
    '#collapsed' => FALSE,
  );
  $form['enable_pm_mail']['enable'] = array(
    '#type' => 'radios',
    '#title' => t('Receive email notification for incoming private messages?'),
    '#options' => array(
      PM_EMAIL_NOTIFY_DISABLE => t('No'),
      PM_EMAIL_NOTIFY_ENABLE => t('Yes'),
    ),
	'#default_value' => isset($edit['enable']) ? $edit['enable'] : 1,
  );
  return $form;
}
      break;
}
}

So yeah... it works but I have a feelings it's also fairly dirty... Any thoughts?

Berdir i'm not ignoring your request for me to provide a patch. I've never done it before. I had a quick look and, it looks like something I'll have to learn later this week. It does look a bit intimidating.

Also I would there be a need for pm_email_notify_user_settings_form() after these changes?

After further testing this doesn't work at all. All it does it add the form but the changes don't take effect.

Okay I made those small changes. I changed 'enable' to 'pm_send_notifications' I'm not sure what you mean by converting the function pm_email_notify_user_settings_form_submit to hook_user($op = 'submit'). I tried to have hook_user as... hook _user($op = 'submit', &$edit, &$user, $category = NULL) if thats what you meant. I also took a look at the guestbook module and the code is as follows.

function guestbook_user($op, &$edit, &$user, $category = '') {
  $guestbook_mode = variable_get('guestbook_mode', GUESTBOOK_SITE_GUESTBOOK | GUESTBOOK_USER_GUESTBOOKS);
  if ($guestbook_mode & GUESTBOOK_USER_GUESTBOOKS) {
    switch ($op) {
      case 'view':
        if (user_access('access user guestbooks') && empty($user->guestbook_status)) {
          $title = t("Read @username's guestbook.", array('@username' => $user->name));
          $link  = l(t('View recent guestbook entries'), "user/$user->uid/guestbook", array('attributes' => array('title' => $title)));
          $user->content['summary']['guestbook'] = array(
            '#type' => 'user_profile_item',
            '#title' => t('Guestbook'),
            '#value' => $link,
            '#attributes' => array('class' => 'guestbook'),
          );
        }
        return;

      case 'form':
        if ($category == 'account') {
          $form['guestbook'] = array(
            '#type' => 'fieldset',
            '#title' => t('User guestbook'),
          );
          $form['guestbook']['guestbook_status'] = array(
            '#type' => 'radios',
            '#title' => t('Status'),
            '#default_value' => isset($edit['guestbook_status']) ? $edit['guestbook_status'] : 0,
            '#options' => array(t('Enabled'), t('Disabled')),
          );
          $form['guestbook']['guestbook_send_email'] = array(
            '#type' => 'checkbox',
            '#title' => t('Send email notification'),
            '#description' => t("Uncheck if you don't wish to be notified of new entries to your guestbook."),
            '#default_value' => isset($edit['guestbook_send_email']) ? $edit['guestbook_send_email'] : 0,
          );
          $form['guestbook']['guestbook_intro'] = array(
            '#type' => 'textarea',
            '#title' => t('Intro text'),
            '#default_value' => isset($edit['guestbook_intro']) ? $edit['guestbook_intro'] : '',
            '#cols' => 70,
            '#rows' => GUESTBOOK_TEXTAREA_ROWS,
            '#description' => t('The text that appears on top of your guestbook.'),
          );
          return $form;
        }
    }
  }
}

Ands heres my version of hook_user

 function mymodule_user($op = 'submit', &$edit, &$user, $category = '') {
   switch ($op) {
    case 'form': // Here we add the email notify form from privatemsg to the edit profile page.
 if ($category == 'account') {
  $form['enable_pm_mail'] = array(
    '#type' => 'fieldset',
    '#title' => t('Privatemsg e-mail notification'),
    '#collapsible' => TRUE,
    '#collapsed' => FALSE,
  );
  $form['enable_pm_mail']['pm_send_notifications'] = array(
    '#type' => 'radios',
    '#title' => t('Receive email notification for incoming private messages?'),
    '#options' => array(
      PM_EMAIL_NOTIFY_DISABLE => t('No'),
      PM_EMAIL_NOTIFY_ENABLE => t('Yes'),
    ),
	'#default_value' => isset($edit['pm_send_notifications']) ? $edit['pm_send_notifications'] : 0,
  );
  return $form;
}
      break;
}
}

Okay well as you might be able to tell i'm doing this totally by trial and error. Thanks for your patience.

I added the submit case but still doesn't work... I hope I'm at least getting a bit closer.

 function fp_privatemsg_user($op, &$edit, &$account, $category = NULL) {
if ($$category == 'account') {
  
switch ($op) {

case 'form':
  $form['enable_pm_mail'] = array(
    '#type' => 'fieldset',
    '#title' => t('Privatemsg e-mail notification'),
    '#collapsible' => TRUE,
    '#collapsed' => FALSE,
  );
  $form['enable_pm_mail']['pm_send_notifications'] = array(
    '#type' => 'radios',
    '#title' => t('Receive email notification for incoming private messages?'),
    '#options' => array(
      PM_EMAIL_NOTIFY_DISABLE => t('No'),
      PM_EMAIL_NOTIFY_ENABLE => t('Yes'),
    ),
	'#default_value' => isset($edit['pm_send_notifications']) ? $edit['pm_send_notifications'] : 1,
  );
  return $form;
break;

case 'submit':
db_query("UPDATE {pm_email_notify} SET email_notify_is_enabled = %d WHERE user_id = %d", $edit['pm_send_notifications'], $account->uid);
break;

	}
  }
}

FJGamer I appreciate what your trying to say, but I actually don't have a problem with it. Personally Bendir has helped me with a lot of previous issues. And at one point, was helping me out with about one issue a day.

Also concerning all the tabs... post another issue. I had similar request and managed to do everything..... except validating this form with hook_menu_alter. I completely changed all the tabs.