We shoudl alter acquia_agent_http_request() along the lines fo the alteration to drupal_http_request() here:

http://drupal.org/node/245990#comment-1200410

CommentFileSizeAuthor
#8 491600_8_Make_Content_Length_Optional_And_Remove_Self_Check.patch2.25 KBAnonymous (not verified)
#7 491600_7_Make_Content_Length_Optional_And_Remove_Self_Check.patch2.26 KBAnonymous (not verified)
#1 nocheck-491600-1.patch1.57 KBpwolanin

Comments

pwolanin’s picture

pwolanin commented
Status: Active » Needs review
StatusFileSize
new nocheck-491600-1.patch1.57 KB

maybe just this?

We don't really need to add the check-again code as core does.

pwolanin’s picture

pwolanin commented
Title: Match code match D6.9 drupal_http_request() » Match code in D6.9 drupal_http_request()
David_Rothstein’s picture

David_Rothstein commented
Status: Needs review » Reviewed & tested by the community

The code makes sense, and I tried it out and acquia_agent_http_request() still seems to work.

It looks like there are some other minor improvements in drupal_http_request() that we don't have, but they look unimportant enough to skip. Overall, it's really a shame that we have to keep a hacked version of this function...

pwolanin’s picture

pwolanin commented

yes, but no other way to check the ssl cert

pwolanin’s picture

pwolanin commented

Here's one core issue, but essentially blocked on Crell's mythical handlers in core: http://drupal.org/node/64866

pwolanin’s picture

pwolanin commented

maybe we shoudl pull this in too? http://drupal.org/node/280240

Anonymous’s picture

Anonymous (not verified) commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new 491600_7_Make_Content_Length_Optional_And_Remove_Self_Check.patch2.26 KB

Includes #1 and #6 with modification listed from http://drupal.org/node/280240#comment-1709162

Anonymous’s picture

Anonymous (not verified) commented
StatusFileSize
new 491600_8_Make_Content_Length_Optional_And_Remove_Self_Check.patch2.25 KB
pwolanin’s picture

pwolanin commented
Status: Needs review » Fixed

thanks Joshua - committed and then branched to DRUPAL-6--1

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.