Currently, nodequeue_clear_confirm() expects a subqueue ID, but it actually gets a subqueue object.

Because of this, the 'Clearing queue "%s" is irreversible. You sure?' message is never shown. The user just sees an empty page with the menu title 'Clear' and no way to clear the queue.

Attached patch fixes this and gets rid of a couple of PHP notices as well.

CommentFileSizeAuthor
nodequeue_clear_notices.patch1.73 KBwulff

Comments

dddave’s picture

Status: Active » Needs review
ezra-g’s picture

Status: Needs review » Fixed

nodequeue_clear_confirm no longer makes this incorrect check. My guess is these fixes made their way into #234004: Drag and drop node ordering.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.