I am using today's (June 5, 2009) roll of 7.x-3.x-dev with today's CVS of D7.

Currently, the admin menu is not using Clean URLs, despite them being enabled on the site.

ie, Logout points to '?q=user/logout'.

CommentFileSizeAuthor
#6 admin_menu-HEAD.client-cache-clear.2.patch1.3 KBsun
#5 admin_menu-HEAD.client-cache-clear.patch1.06 KBsun

Comments

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Assigned: Unassigned » dave reid

I guess we could do something like rebuilding the admin_menu when the clean URL settings form is submitted. I'll work on a patch if that sounds good.

brianV’s picture

brianV commented

Sounds good to me.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Active » Postponed (maintainer needs more info)

Please test again using the latest development snapshot or CVS checkout. #469716: Issue when using custom_url_rewrite was committed recently. Though it's possible that I don't understand this issue.

brianV’s picture

brianV commented
Status: Postponed (maintainer needs more info) » Active

Sun,

As I said, this is using the June 5 dev package, which postdates that commit. I double checked, and that commit is in the code I have.

When I installed admin_menu, clean URLs were off. I later turned them on. Admin_menu is still using the 'dirty' URLs.

I think Dave Reid is on the right track when he says that the menu many need to be rebuilt after enabling clean URLs.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Active » Needs review
StatusFileSize
new admin_menu-HEAD.client-cache-clear.patch1.06 KB
sun’s picture

sun
Primary language German
Location Karlsruhe
commented
StatusFileSize
new admin_menu-HEAD.client-cache-clear.2.patch1.3 KB
brianV’s picture

brianV commented

Tested it out, noticed some strange behaviour...

1. Installed clean D7 from CVS
2. Installed admin menu dev patched with the patch above.
3. Enabled clean URLS

Admin menu still used the dirty URLs, until I flushed all the caches manually, after which it used the clean URLs.

Furthermore, I disabled Clean URLs again, and Admin menu continued to use the clean urls until I once again flushed the cache manually.

Finally, even though clean urls was disabled, the clean URLs were still resolving instead of sending to a 'page not found' like they are supposed to.

edit: testing #6

brianV’s picture

brianV commented

Patch #6 works perfectly.

I still have the issue of clean URLs with clean URLs disabled, and dirty URLs resolving with clean URLs enabled, but that may be a core issue.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

Non-clean URLs always work. That's because clean URLs are simply rewritten by mod_rewrite. Drupal always gets the non-clean URLs.

brianV’s picture

brianV commented
Status: Needs review » Reviewed & tested by the community

excellent

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

Worked perfectly for me now. I think it's ready to commit.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

I can't tell if it's because of this patch or not, but I get the menu disappearing on pages now. :/

EDIT: Nevermind. It was the url_rewrite bug that has been fixed. This is all good now.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Reviewed & tested by the community » Needs work

well, it doesn't work for me. At least, after disabling clean URLs, admin_menu still contains clean URLs.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs work » Reviewed & tested by the community

oopsie. Forgot to rebuild the registry. *gngn*

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Reviewed & tested by the community » Fixed

phew. That was quite hard to back-port.

Thanks for reporting, reviewing, and testing! Committed to all branches.

A new development snapshot will be available within the next 12 hours. This improvement will be available in the next official release.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.