Menu on-the-fly resets custom menu settings [#48178]

Comment	File	Size	Author
#11	menu-otf-settings-4-7.patch	804 bytes	kkaefer

#9	menu-otf-settings.patch	806 bytes	kkaefer

Comment #1

Egon Bianchet CreditAttribution: Egon Bianchet commented 3 May 2006 at 21:19

Version:	4.7.0-beta4	» 4.7.0
Status:	Active	» Closed (fixed)

Can't reproduce it in 4.7.0

Log in or register to post comments

Comment #2

JoshLangner CreditAttribution: JoshLangner commented 29 July 2006 at 17:55

Version:	4.7.0	» 4.7.2
Status:	Closed (fixed)	» Active

I have been able to reproduce this problem in 4.7.2. This is a serious problem for me, because my site uses drop-down menus to operate. If one of the primary links gets edited, the expanded status gets reset, and the drop-downs no longer appear.

Log in or register to post comments

Comment #3

JoshLangner CreditAttribution: JoshLangner commented 29 July 2006 at 18:15

NOTE: This bug is similar to, if not identical to, the bug found here: http://drupal.org/node/48178

Log in or register to post comments

Comment #4

JoshLangner CreditAttribution: JoshLangner commented 29 July 2006 at 18:16

Correction:

This bug is similar to, if not identical to, the bug found here: http://drupal.org/node/18351

(copy-paste isn't exactly as smart as I sometimes think :) )

Log in or register to post comments

Comment #5

kkaefer CreditAttribution: kkaefer commented 21 August 2006 at 22:34

Another report of this bug: http://drupal.org/node/79881

Log in or register to post comments

Comment #6

JoshLangner CreditAttribution: JoshLangner commented 7 September 2006 at 15:58

Here is a related bug: http://drupal.org/node/77569

I'm not certain if this is the Category module's fault or just the built-in menu-on-the-fly's fault.

Log in or register to post comments

Comment #7

venkat-rk CreditAttribution: venkat-rk commented 21 October 2006 at 04:25

Category_menu relies on the core menu system (which includes menu_otf since 4.6), so I would bet it's probably menu_otf

Log in or register to post comments

Comment #8

kkaefer CreditAttribution: kkaefer commented 21 October 2006 at 09:16

Version:

4.7.2

» x.y.z

This bug does still exist in HEAD.

Log in or register to post comments

Comment #9

kkaefer CreditAttribution: kkaefer commented 21 October 2006 at 09:32

Assigned:	Unassigned	» kkaefer
Status:	Active	» Needs review

File	Size
menu-otf-settings.patch	806 bytes

I finally could track down this bug: In the menu fieldset on a node editing form, you can’t specify whether the menu item should be expanded by default or not. That means, the expanded index in the $edit array was missing. However, menu_edit_item_save just checked for $edit['expanded']. If it’s false or not set, the MENU_EXPANDED constant will be removed from the menu item. Now, this function checks first if the expanded index is present or not before altering $type.

Log in or register to post comments

Comment #10

profix898 CreditAttribution: profix898 commented 21 October 2006 at 13:30

Status:

Needs review

» Reviewed & tested by the community

Code looks good and works as advertised.

Log in or register to post comments

Comment #11

kkaefer CreditAttribution: kkaefer commented 22 October 2006 at 18:46

File	Size
menu-otf-settings-4-7.patch	804 bytes

This patch is specifically for 4.7! For HEAD, use the patch above.

Log in or register to post comments

Comment #12

gemini CreditAttribution: gemini commented 29 October 2006 at 03:53

Not sure if this is the right place to post.

In my case I have top menu and side navigation which is set to be available in the post authoring form. Every time I go to edit a node that linked from top menu - menu item from the top menu appears in the menu settings and the parent item is restricted to side navigation. By updating the node it creates the menu in the side navigation which makes is redundant (it is already in top menu). By removing menu item name - it removes it from the original top navigation. So, restricting parent items in the administrative menu settings only to one menu still affects other menus that so not appear on the node creation/edition page. Can this be avoided?