When "Collapse fieldsets on modules page" is enabled, the fieldsets collapse properly on admin/build/modules but do not collapse on admin/build/modules/list (which as near as I can tell is the exact same page, and linked to from Admin Menu)

Assuming that this isn't by design, here is a patch that corrects the behavior.

(It's possible that this is by design, and that admin/build/modules/list is supposed to show all modules uncollapsed. If this is the case, the wording on the link to the that page should be changed from "List" to "Show all" or something.")

Comments

sun’s picture

Status: Needs review » Needs work

Thanks!

We want to use strpos() here instead.

danepowell’s picture

Status: Needs work » Needs review
StatusFileSize
new601 bytes

Fair enough :)

sun’s picture

Status: Needs review » Reviewed & tested by the community

Oops. You should have mentioned that you already considered to use strpos(), but that would also apply to admin/build/modules/uninstall then. ;)

Original patch is ready to go then. :P

sun’s picture

Status: Reviewed & tested by the community » Fixed

Thanks for reporting, reviewing, and testing! Committed to all 3.x branches.

A new development snapshot will be available within the next 12 hours. This improvement will be available in the next official release.

dave reid’s picture

@danep: FYI, per the coding standards, make sure your booleans like 'true' are in all caps like 'TRUE'. Just so you know. :)

danepowell’s picture

@Dave: I'm definitely still learning, thanks for the tip :)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

gpk’s picture

Hmm I used to use the List link to view all the modules in uncollapsed fashion. Useful when you can't remember which section a module lives in.

Not the end of the world I suppose, will just have to keep flipping the checkbox on the settings page when I need to view the complete list.

danepowell’s picture

Maybe a simple "expand all" link is what is needed there. You should probably open another issue if you're looking for something like that.