If I chose "do nothing, leave the old alias intact" as the option for "update action", I expect that new aliases get created for nodes that do not yet have any aliases.

The code does not so that, though.

Attached patch fixes this.

CommentFileSizeAuthor
pathauto.patch918 bytesgerhard killesreiter

Comments

herzbube’s picture

I'm on 6.x-1.2 (with Drupal 6.14), same issue.

kentr’s picture

This looks like a duplicate of #285042: "Do Nothing" Should Still create aliases for unaliased items. Cool that you made a patch. I think it would help others if you'd move the patch over to that thread if this is a duplicate.

Looking forward to testing the patch.

Proct0t’s picture

worked fine for me, thanks!

Proct0t’s picture

Status: Needs review » Needs work

wait, i take that back... the call to _pathauto_existing_alias_data() will return an empty $update_data when pathauto_update_action == 0, which will cause this patch to always believe the current alias to be non-existent... currently i simply copied the existing alias function to replace the call and moved "case 0" to just below "case 3"....

dave reid’s picture

Status: Needs work » Closed (duplicate)