Will Comment Notify work with the module Node Comments? http://drupal.org/project/nodecomment

Comments

greggles’s picture

Title: Will Comment Notify work with Node Comments? » Provide support for nodecomment in commentnotify
Component: Documentation » Code
Category: support » feature
Status: Active » Closed (won't fix)

No, this isn't really possible and probably wouldn't make sense to make possible.

Comment notify is meant to be a very lightweight module. If something comes along that we could integrate with that adds bloat to the code then it has to be really popular/worthwhile. There are only a few hundred users of nodecomment, so it's not worth adding bloat code.

greggles’s picture

Title: Provide support for nodecomment in commentnotify » Provide support for node comment in commentnotify
Status: Closed (won't fix) » Active

After #483532: Provide integration with node comments let's open for further discussion.

Dries made a call for a module like this http://buytaert.net/comment-notifications-via-email and since then I have worked to make comment_notify "core worthy." So, what guides me there?

* Coding standards/best practices compliant (with tests...even if they are small so far, testing mail is "hard")
* Simple UI - I've received some help from Jeff Noyes on this point, and I think the user side is good and karens has a good idea for the admin interface mixed up inside #468072: Send message to poster immediately and then I did some basic usability testing which found #417584: make the "available subscription modes" a permission, #417582: if only one subscription mode is enabled, users should only see one option in their edit page, and #417542: if user's don't have the ability to post nodes don't confuse them about a node-notify default and better db insert/update code. This makes it hard to accept new features, but...
* Lightweight - this is the toughest one to deal with because it means saying "no" to lots of great feature requests.

I'm also very conscious of the comment notification module space and want to make sure that we don't "improve" this module so much that it becomes a competitor to the other modules. It should have a specific well bounded purpose.

Having done this work towards a core-worthy comment_notify, and noting the other modules, my major concern with this idea is how to do it in a way that comment_notify is not made to be more complex than necessary to provide support for Node Comments.

So, if we can make very light changes to comment_notify and have heavy lifting in Node Comments, awesome.

greggles’s picture

Status: Active » Closed (won't fix)