Button translations

That's a really great idea. :)

I am reusing this issue for a patch which makes the custom text translatable.
Maybe we want also the alt text translated for images?

About the background image for the custom text, I am setting it just via css:

.da2a_button {
  padding-left: 20px;
  background: url(images/share_16_16.png) center left no-repeat;
}

Regards,
Antonio

Hmm... I like the thinking behind the patch, but translation doesn't make sense in this case because the text is variable (user inputted) and there's no default value.

Re: background-image, I kind of prefer that method myself anyway. Thanks for sharing. :)

@micropat: maybe instead of this rough approach of using t() we could mark the _input_filed_ for custom text as a multilanguage field, I have to look into that, but the point stands: it makes perfectly sense to have a user defined string translatable (think to multilanguage sites); do we agree on that?

Regards,
Antonio

Ok, in order to have the custom text as a multilingual variable it is enough to add 'addtoany_link_text' to $conf['i18n_variables'] in your site settings.php.

This is ok to me and keeps the multilanguage complexity out from AddToAny. Patch discarded and issue closed?

Thanks,
Antonio

Some other modules define their own multilingual variables:
http://blog.eood.cn/make-user-inputed-variables-translatable-in-drupal

maybe addtoany could do that instead of the patch in #3, and instead of leaving that to the site specific config like stated in #6:

global $conf;
$conf['i18n_variables'][] = 'addtoany_image_attributes';
$conf['i18n_variables'][] = 'addtoany_link_text';

Comments?

I like that method! Thanks very much for your persistence on this issue.

Would you like to offer a patch against the latest version?

Here we are. Patch is against 6.x-3.x branch, you can use git am to apply it so I get attribution in the git history.

Thanks,
Antonio