Hi. I have some products for which my clients do not use the Stock or Attributes features, but with this module enabled, which globally affects all products, these select products are listed as Out of Stock, which suffice it to say is not the desired effect.

In fact, uc_multi_stock basically accomplishes what we want already -- when a customer tries to add an item from an external cart link (our shop experience) that's out of stock, they of course get the error that it's out of stock.

What we hoped for with Attribute Stock Filter, as the name might suggest, is that it would simply "filter" those products for which the Stock feature is enabled and have a stock at zero or less from anywhere in the display to the customer. Sadly this seems not so, so this module is otherwise useless to us for now.

I appreciate the effort though -- just some feedback regardless.

Comments

maikeru’s picture

maikeru commented

Same problem for me.

Although I think the quickest way to fix it is to add an if statement at line 78 of uc_attribute_stock_filter.module.

if (is_numeric($stock->count)) {

.....

}

Seems to work now.

Michael

danny_joris’s picture

danny_joris commented

I agree that this is an annoying problem. This module is great, but there should at least be an option to choose if you want non-stock products to be marked as 'out of stock' or not.

Clint Eagar’s picture

Clint Eagar commented

I agree, if stock isn't being tracked on a product then this module should ignore that product. Other than that, this is an excellent module.

minneapolisdan’s picture

minneapolisdan commented

thanks maikeru, that fixed it for me. Maybe an update or patch will be added at some point ( I have no idea how to do that kind of thing). But for now, that's a great fix, so my client doesn't have to go back and activate stock levels for hundreds of products, just the ones they want to track stock on.

maikeru’s picture

maikeru commented

Actually, it looks like its included in a patch now:

See: http://drupal.org/node/432870#comment-1880116

Theres a line in the provided patch which reads:

if ($stock->active && $stock->count < 1) {

Mixologic’s picture

Mixologic
He/Him/His
Primary language English
Location Portland, OR
commented
Category: feature » bug

There is still an issue with items that are not stock items being filtered out. Line 85:

      $result = db_query("SELECT a.combination AS combination, s.stock AS stock, s.active FROM {uc_product_adjustments} a LEFT JOIN {uc_product_stock} s ON a.model = s.sku WHERE a.nid = %d", $form['nid']['#value']);
      $available = array();
      while ($data = db_fetch_object($result)) {
        $combo = unserialize($data->combination);
        if ($data->stock || !$data->active) { // Stock is available or stock tracking is NOT active
          $available = array_merge($available, array_values($combo)); // Merge value into array
        }
      }

This is making the assumption that *every* attribute option combo has an adjustment, which isnt true if you set the attribute option to the same SKU as the master SKU on the product. In that case Ubercart does not make an additional adjustment in the uc_product_adjustments table. And these are being filtered out regardless of whether or not they are stock items.