As noted in #234004: Drag and drop node ordering I'll work on moving the admin parts of the nodequeue to a separate file.

I'll start this work when (!) #234004: Drag and drop node ordering is done.

CommentFileSizeAuthor
#3 462290-move_admin_functions_to_separate_admin_inc-D6.patch87.61 KBamateescu
#3 462290-move_admin_functions_to_separate_admin_inc.patch86.28 KBamateescu

Comments

mrfelton’s picture

mrfelton commented

Following on from #660494: Break up nodequue.module to reduce Nodequeue's memory foot print which was just marked as a duplicate of this one...

Nodequeue is among the top 3 memory consumers in a site with over 180 modules installed (identified using the 2bits memory patch - http://2bits.com/articles/measuring-memory-consumption-by-drupal-bootstr...). Webform is the biggest offender, but only marginally.

The raw data (the top bit only):

PHP                       152510544
Drupal                    150187720
Total data                101650960
Bootstrap code            59085536
Total code                48536760
code-webform              1193200
code-nodequeue            1167488
code-location             1131504
code-node                 1084288
code-date_api             1077280
code-simplenews           1049472
code-content              967024
code-ddblock              879712
code-comment              838096
code-system               799720
code-textsize             737552
code-filefield            737392
code-forward              689192
code-faq                  627728
amateescu’s picture

amateescu commented
Assigned: wulff » amateescu
Priority: Normal » Critical

I will take a stab at this sometime this week.

amateescu’s picture

amateescu commented
StatusFileSize
new 462290-move_admin_functions_to_separate_admin_inc.patch86.28 KB
new 462290-move_admin_functions_to_separate_admin_inc-D6.patch87.61 KB

And here they are, hot off the press patches for 6.x and 7.x.

Testing my 6.x dev site with Devel Performance, I got a 25% decrease in memory usage for the nodequeue module. Very interested in hearing your results :)

amateescu’s picture

amateescu commented
Status: Active » Needs review
amateescu’s picture

amateescu commented
Status: Needs review » Fixed

Commited to 6.x and 7.x. Don't forget to clear your cache because this patch changed almost all items from hook_menu().

http://drupalcode.org/project/nodequeue.git/commit/531a714
http://drupalcode.org/project/nodequeue.git/commit/fd3daf6

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.