We need to add additional tests, especially in the contribs.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

NancyDru’s picture

Status: Active » Postponed
NancyDru’s picture

See #475634: Since 01/01/1970 - 01:00 shown this reference error. for one type of test that should be done.

Feel free to add other comments specifying the types of tests you would like to see.

NancyDru’s picture

Component: Performance » Testing
jonathan1055’s picture

Version: 6.x-2.x-dev » 7.x-1.x-dev
Priority: Minor » Normal
Issue summary: View changes
Status: Postponed » Active

Moving to the 7.x issue queue. What are the most important additional tests that we need?

GStegemann’s picture

I will think about.

But first, I think, we should decide about issues #2320971: Weblinks Block Module Error In Code and #314369: Show image in block using D7 core image functionality.

jonathan1055’s picture

Status: Active » Needs review
FileSize
8.14 KB

As mentioned in the block issues above, here is a test file for the Blocks sub-module. Doing it in a separate file means that these tests can be run (and developed) separately from the main test file.

It was useful writing these tests because it actually showed up one fault in the block configure function, where I was not sufficiently protecting the image style element on block save.

The patch, therefore, has changes to .module, .info and changelog.txt, plus the new file .test

GStegemann’s picture

OK, I will test this patch later today or tomorrow.

GStegemann’s picture

Status: Needs review » Reviewed & tested by the community

The patch is OK. Tested and works.

  • jonathan1055 committed 353bea1 on 7.x-1.x
    Issue #460622 by jonathan1055: Automated testing for Weblinks Blocks
    
jonathan1055’s picture

Status: Reviewed & tested by the community » Fixed

Thanks for testing - it is good to get the Blocks sub-module at least partly covered by automated tests.
Marking this as fixed - we can always re-open and add to it when we want to write more tests.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

jonathan1055’s picture

Title: Additional tests » Additional automated tests
Status: Closed (fixed) » Active

I have added another few tests to the Blocks file, as a recent patch in #2443235: Add block css using the #attached property had a major fault which could have been trapped. I've also added a test to weblinks.test to view the first link in full-page mode, as this was not done.
I think we might as well leave this issue open, as there are bound to be more tests that we add, and if the issue is closed(fixed) it wont show up on our dashboard.

The commit is http://cgit.drupalcode.org/weblinks/commit/?id=03054a4 but it does not seem to have been added to this issue automatically yet.

[edit: The wif-fi on the train was a bit dodgy, and the operation seems to have completed the git push -u origin 7.x-1.x but failed or timed out before updating this issue. Also the issue was in 'closed' state at that time, but that should not have prevented the automatic posting of the commit]

GStegemann’s picture

I think we might as well leave this issue open

Is OK for me.