When importing a Views 1 view, the Filefield display format is not preserved. Patch to follow.

Members fund testing for the Drupal project. Drupal Association Learn more


Darren Oh’s picture

Status: Active » Needs review
1.53 KB

Patch attached.

Darren Oh’s picture

Title: Format not preserved in views import » Conversion from Views 1
Status: Needs review » Reviewed & tested by the community
3.44 KB

Added filter and argument conversion. I've tested this, and since there haven't been any others interested in testing, I'm marking it as ready to be committed.

quicksketch’s picture

Status: Reviewed & tested by the community » Needs review

Hey Darren Oh, I'm planning on getting this in, I just haven't had time to review this yet. Do you know of any problems with the code (since this version is notably longer than the first version).

This definitely seems unnecessary:

+          foreach ($content_field['columns'] as $column => $attributes) {
+          }

I still haven't applied to test it out, since it requires a bit of set up.

Darren Oh’s picture

This version is longer because it fixes all problems, not just one. There are no remaining issues that I know of. The unnecessary lines are removed in the attached patch.

quicksketch’s picture

Category: bug » feature
Status: Needs review » Fixed

Thanks Darren Oh! Any implementation is better than none, so I've committed your patch. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.