make min and max blank values means inf. in filter operator 'between'

+1 for this to be integrated

Thats a good feature, but why not use the is greater or is smaller then, this would do the same.

It simplifies form. Lets say i want to have both 'between' 'greater/less than' and i dont want to expose operator. This is pretty handy

Im using this one for mine purpose:

function op_between($field) {
    if ($this->operator == 'between') {
			if($this->value['min']=='' AND $this->value['max']!=''){
			$this->query->add_where($this->options['group'], "$field <= %d", $this->value['max']);
			}
			elseif($this->value['min']!='' AND $this->value['max']==''){
			$this->query->add_where($this->options['group'], "$field >= %d", $this->value['min']);
			}
			else{
				$this->query->add_where($this->options['group'], "$field >= %d", $this->value['min']);
				$this->query->add_where($this->options['group'], "$field <= %d", $this->value['max']);
			}
    }
    else {
      $this->query->add_where($this->options['group'], "$field <= %d OR $field >= %d", $this->value['min'], $this->value['max']);
    }
  }

and for float type views_handler_filter_float.inc on line 10.

function op_between($field) {
    if ($this->operator == 'between') {
			if($this->value['min']=='' AND $this->value['max']!=''){
			$this->query->add_where($this->options['group'], "$field <= %f", $this->value['max']);
			}
			elseif($this->value['min']!='' AND $this->value['max']==''){
			$this->query->add_where($this->options['group'], "$field >= %f", $this->value['min']);
			}
			else{
				$this->query->add_where($this->options['group'], "$field >= %f", $this->value['min']);
				$this->query->add_where($this->options['group'], "$field <= %f", $this->value['max']);
			}
    }
    else {
      $this->query->add_where($this->options['group'], "$field <= %f OR $field >= %f", $this->value['min'], $this->value['max']);
    }
  }

Emil

This would be better served if it were a real patch :)

This needs someone to work on it.

I'm wondering whether it makes sense to call another op_simple here, if the cases mentioned above should be used.

You mean, if one or the other is empty, pass through to op_simple? I think the operator would have to be mangled for that to really work.

You mean, if one or the other is empty, pass through to op_simple? 

Exactly.

Oh i see the problem. What about adding an optional value parameter to the op callbacks?

Hello, I also experience this in the 7.x version with (only) a "between" operator on a filter:

- when not entering a value all values are shown (right behavior)
- when only entering the max field the list is limited (right behavior)
- when only entering the min field no results are returned!

I'm filtering an integer field.


Greetings Wappie

This seems to be related to #856238: exposed filter of created date with "Is between" and optional returns empty results maybe. Feel free to put it 6.x again!

For D7 you can use change file: views_handler_filter_numeric.inc like this:

function op_between($field) {
    if ($this->operator == 'between') {
      if ($this->value['max'] == "") {
        $this->query->add_where($this->options['group'], $field, $this->value['min'], '>=');
      }
      else {
        $this->query->add_where($this->options['group'], $field, array($this->value['min'], $this->value['max']), 'BETWEEN');
      }
      
    }
    else {
      $this->query->add_where($this->options['group'], db_or()->condition($field, $this->value['min'], '<=')->condition($field, $this->value['max'], '>='));
    }
  }

+1

+1

When I use a filter with no maximum (['max']) value I don't see results in views. Is the problem still relevant?