Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Hi,
I know this might be unnecessary, but it does make it easier to read through the code and use coder to identify true issue, so I have put together a patch that cleans up the majority of the coder reported issues, coding standards, etc, and also added a few TODOs for a few sections that could be improved.
Chances are I will submit a few more patches for things to do with improving integration with FileField Paths and ImageField Tokens and those patches will rely on this patch.
Cheers,
Deciphered.
Comment | File | Size | Author |
---|---|---|---|
#1 | image_fupload-HEAD-450250-code_cleanup-2.patch | 125.66 KB | Deciphered |
image_fupload-HEAD-code_cleanup-1.patch | 124.4 KB | Deciphered |
Comments
Comment #1
Deciphered CreditAttribution: Deciphered commentedMissed a couple changes on my merge.
Updated patch attached.
Comment #2
grandcat CreditAttribution: grandcat commentedGreat! As I can see, you did a very good job, thank you very much.
I will take a closer look at the changes before submitting to CVS Head.
Comment #3
grandcat CreditAttribution: grandcat commentedWill be done soon.
Comment #4
grandcat CreditAttribution: grandcat commentedSubmitted to CVS Head. Deciphered, thank you.