For example:

http://drupal.org/node/443618/revisions/view/528984/531188

All I did was lock comments on a (very ugly) issue thread that needed to be closed. However, once I did, the node no longer knows its title:

http://drupal.org/node/443618

Lame. Pretty sure this is a bug in project_issue itself, due to the hoops we're jumping through to make it so you can't change issue meta-data when editing an issue node directly. I haven't investigated closely, but wanted to submit an issue. If editing issues were any more common, I'd call this "critical". It's certainly a 6.x-1.0 blocker...

CommentFileSizeAuthor
#2 pi_fix_title_deletion.patch619 byteshunmonk

Comments

Anonymous’s picture

I see that this obviously happened, but I am unable to repeat it. This is on a local install using drupalorg_testing.

hunmonk’s picture

Assigned: Unassigned » hunmonk
Status: Active » Needs review
StatusFileSize
new619 bytes

further local testing seems to indicate the title is only lost when revisions are enabled for a node. looking at the code, we're not passing through the node title if we're blocking metatdata. i'm not sure why or how it's getting passed in the case where revisions are disabled, but i think we really should be explicitly passing a value anyways.

attached patch seems to do the trick, whether revisions are enabled or not.

dww’s picture

Status: Needs review » Reviewed & tested by the community

Code looks good. Patch is a reasonable solution to the problem. Tested -- confirmed the bug when editing issues with a new revision, and confirmed the patch fixes it. Thanks!

hunmonk’s picture

Assigned: hunmonk » Unassigned
Status: Reviewed & tested by the community » Active
Issue tags: -6.x-1.0 blocker +needs drupal.org deployment

committed to HEAD and 5.x-2.x-dev. i couldn't reproduce the problem in 5.x, but node titles have been handled by node modules since 4.7, so it seems appropriate to have the patch in 5.x for consistency. i did test it in 5.x, and it works just fine.

setting to active for d.o deployment

dww’s picture

Status: Active » Fixed
Issue tags: -needs drupal.org deployment

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.