Node types that don't have fieldmaps, still have a salesforce tab. See the attachment. This is redundant. Hide it by returning FALSE in the hook_menu() item's access callback.

This is a usability bug.

CommentFileSizeAuthor
#4 444552-salesforce-tab-access.patch6.03 KBaaronbauman
#1 444552.patch4.15 KBBevan
About us | sf.lcl_.png48.04 KBBevan

Comments

Bevan’s picture

Bevan commented
Status: Needs work » Needs review
StatusFileSize
new 444552.patch4.15 KB

I patched this but have not tested yet, since I am reserving the passwordExpired state of my testing accounts to develop/test that patch first.

abowers’s picture

abowers commented

I've applied this and have done a bit of cursory testing - the tab does not show up for objects without a fieldmap, and does when they do. The manual export/import buttons still seem to be working. I will keep this patch in place as I am testing my setup for creating objects automatically as well. Is there any specific functionality that you would like me to take a look at for this patch?

So excited about this module, by the way - it will be quite helpful for our organization.

legion80’s picture

legion80 commented

Is it possible to get a new patch for this? I tried to apply it to the latest with #476978: Implement "Object Setup" Feature and #536292: Automatic syncing can not be changed after fieldmap-creation and it didn't work, and I'm unsure how to apply the diff code manually based on what I'm seeing in the patch.

aaronbauman’s picture

aaronbauman
he/him
commented
Title: Don't show Salesforce tab on nodes that don't have fieldmaps » Don't show Salesforce tab on drupal objects that don't have fieldmaps
StatusFileSize
new 444552-salesforce-tab-access.patch6.03 KB

Patch #1 works great for me.
I added similar functionality for sf_user and removed an erroneous edit to salesforce_api.admin.inc

re comment #3 from legion80:
I was able to apply the patch from #1 to the latest version of 6-2-dev, and you should be able to do the same for this version of the patch. Since this patch does not require any other patches, including the 2 you mentioned, you're best bet is to work from a fresh copy from CVS.

Bevan’s picture

Bevan commented
Status: Needs review » Reviewed & tested by the community
aaronbauman’s picture

aaronbauman
he/him
commented
Status: Reviewed & tested by the community » Fixed

committed http://drupal.org/cvs?commit=330860

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.