Warning when updating content.

In: xmlsitemap_node.module

I "fixed" the problem by changing the UPDATE query to check explicitly for NULL and do the right thing by emitting a NULL in that event. The real problem is that the check for !== FALSE will be TRUE if $node->priority_override is NULL, so the fix should probably be for FALSE to change to NULL (or the operation changed to != instead of !==).

Here's what I did as a work around:

    case 'update':
      if (!isset($node->priority_override)) {
        $priority_override = db_result(db_query("SELECT priority_override FROM {xmlsitemap_node} WHERE nid = %d", $node->nid));
        $node->priority_override = $priority_override !== FALSE ? $priority_override : 'NULL';
      }
      db_query("UPDATE {xmlsitemap_node}
        SET previously_changed = last_changed, last_changed = %d, priority_override = %s
        WHERE nid = %d",
        $node->changed,
        ($node->priority_override === NULL ? 'NULL' : $node->priority_override),
        $node->nid
      );

Here's probably what should happen...

    case 'update':
      if (!isset($node->priority_override)) {
        $priority_override = db_result(db_query("SELECT priority_override FROM {xmlsitemap_node} WHERE nid = %d", $node->nid));
        $node->priority_override = $priority_override != FALSE ? $priority_override : 'NULL';
      }
      db_query("UPDATE {xmlsitemap_node}
        SET previously_changed = last_changed, last_changed = %d, priority_override = %s
        WHERE nid = %d",
        $node->changed,
        $node->priority_override,
        $node->nid
      );

Best,

Dick Munroe