This commit: http://drupal.org/cvs?commit=197606 made it protected. This means that the Views class can't access it. #440788: Patch for 3 small errors - $id, get_filters(), and apachesolr_modify_query/OG problem

This patch reverts that small change. Either do this or an accessor function? get_id() ?

Comments

Scott Reynolds’s picture

Scott Reynolds commented

help if i provided a patch
Index: Solr_Base_Query.php
===================================================================
RCS file: /cvs/drupal-contrib/contributions/modules/apachesolr/Solr_Base_Query.php,v
retrieving revision 1.1.4.29
diff -u -p -r1.1.4.29 Solr_Base_Query.php
--- Solr_Base_Query.php 23 Apr 2009 20:03:54 -0000 1.1.4.29
+++ Solr_Base_Query.php 23 Apr 2009 21:26:35 -0000
@@ -55,7 +55,7 @@ class Solr_Base_Query implements Drupal_
/**
* Each query/subquery will have a unique ID
*/
- protected $id;
+ public $id;

/**
* A keyed array where the key is a position integer and the value

pwolanin’s picture

pwolanin commented

Oh, crud -that did break the subquery code, didn't it.

I don't feel that strongly about it being public or not, just thought we didn't want the value getting changed externally.

pwolanin’s picture

pwolanin commented
Status: Needs review » Fixed

committed to change it back to public for now.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.