Description of {files} status flag wrong way round

I think joachim is correct. It is also incorrect in Drupal 7.

See:
- http://api.drupal.org/api/function/system_schema/7 (table "files", field "status"), where it says "'A bitmapped field indicating the status of the file the least sigifigant bit indicates temporary (1) or permanent (0). Temporary files older than DRUPAL_MAXIMUM_TEMP_FILE_AGE will be removed during a cron run.
- http://api.drupal.org/api/function/system_cron/7 where it removes files with status bit not equal to FILE_STATUS_PERMANENT
- http://api.drupal.org/api/constant/FILE_STATUS_PERMANENT/7 (defined to be 1).

Significant is also misspelled in the D7 doc.

Here's a D7 patch.

Would we patch D6 for this? I wasn't sure if it would fall under string freeze. Anyway, D7 first...

Setting back to Needs Review in hopes that the patch will get retested. The test bot was apparently malfunctioning (I had about 7 patches fail in that time period, all were doc, none broke the HEAD install I am pretty sure).

Test bot problem

Committed to CVS HEAD. Thanks!

Open issue for this in 6.x at #292686: files.status documented with opposite values.

Oh. We should reopen this issue and port to D6.

The test bot won't go back and test past patches unless you hit "retest".

Anyway, the patch doesn't apply in D6...

How about this?

Committed, thanks.