When making theme and module disabled in nagios module admin, the need to update my themes and modules are reported to Nagios...

Thanks !

CommentFileSizeAuthor
#4 nagios-436650-HEAD.patch2.65 KBhelmo
#4 nagios-436650-d6.patch2.7 KBhelmo
#1 drupal_nagios_settings_description.patch2.3 KBhelmo

Comments

helmo’s picture

helmo commented
Status: Active » Needs review
StatusFileSize
new drupal_nagios_settings_description.patch2.3 KB

The checkboxes for themes and modules only function to gather performance data.

The "WARNING=Module and theme update status" is generated by the 'requirements' checkbox which calls the requirements checking code from Drupal core.

I agree that the settings page is not clear about this.
The attached patch tries to clarify this.

kbahey’s picture

kbahey commented
Status: Needs review » Needs work

Your patch is unrelated to this issue's title.

I see that it is a good idea.

However some comments:

1. We do not do a t() on a variable. The t() should be in the array definition itself. So move it there.

2. You need to prepare a similar patch for the performance module as well.

3. We need D6 and D7 versions of this patch.

helmo’s picture

helmo commented
Assigned: Unassigned » helmo
helmo’s picture

helmo commented
Title: Nagios module configuration not taken into account » Nagios module settings page unclear
Priority: Critical » Normal
Status: Needs work » Needs review
StatusFileSize
new nagios-436650-d6.patch2.7 KB
new nagios-436650-HEAD.patch2.65 KB

> However some comments:
>
> 1. We do not do a t() on a variable. The t() should be in the array definition itself. So move it there.

done

> 2. You need to prepare a similar patch for the performance module as well.

I'm not entirely sure what you mean here. As far as I can see the performance module does not provide a hook_nagios_settings() implementations.

> 3. We need D6 and D7 versions of this patch.
done

kbahey’s picture

kbahey commented
Status: Needs review » Fixed

Thank you.

I committed your change to both 6.x and HEAD.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.