Closed (fixed)
Project:
Panels
Version:
6.x-3.0-alpha4
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
16 Apr 2009 at 20:04 UTC
Updated:
2 Jun 2009 at 22:10 UTC
Jump to comment: Most recent file
Comments
Comment #1
merlinofchaos commentedThat height and width are set by javascript which is setting the modal to 80% of the viewable area. How does this break themes?
(Also, 'needs' review means there is a patch attached).
Comment #2
NeoID commentedSorry for setting the wrong status...
On my site the page becomes very long and my footer ends before the page (note the space after the blue footer). It's much longer then on the screenshot and if I remove the height using firebug the theme looks good again... Is setting the height really important or can it (or can I) remove it?
Comment #3
merlinofchaos commentedWow, that's really strange to get that result. That totally doesn't match the height and width that are being set, either. I don't know why this would be.
You can't remove the height setting, like I said, it sets it to 80% of the current viewport width. It shouldn't change the rest of the...hm. You know, I think if you're using alpha4 you're probably not even getting the dynamicly sized modal. I only JUST added that. That's even weirder.
Comment #4
merlinofchaos commentedAhh, the modal backdrop is what darkens everything that isn't the modal. It normally doesn't have any interaction problems with the rest of a theme, so this might indicate there's something wrong with your HTML or CSS that this is hilighting.
Comment #5
merlinofchaos commentedSomewhere along the way certain css properties for the modal backdrop had gotten lost and I never noticed. So it was putting it in totally the wrong place. Today's checkin should fix this. By placing it position: absolute it should not do that to your theme anymore.