Using $form_state instead of $_POST in cart forms

What version of Ubercart did you apply the patch to ? The issue is marked 6.x-2.0-beta6.

This patch changes the function signature of checkout pane callbacks, this will break all existing contrib modules that implement hook_checkout_pane, and therefore I do not think this should be implemented mid-release cycle.

I guess it would be possible to extend the checkout pane information arrays to identify whether they use the old or new function signature style and execute the callback accordingly - though that will also make the code somewhat more complicated.

@longwave: Yeah, that's what I was thinking too, any contrib that implements a checkout pane will break.

I'm not even sure the patch still applies, it's so old. Hence my question in #3.

I'm all in favor of the goal of the initial patch, but I suspect this will have to be done in the 7.x branch at this point in time. And since the whole checkout pane system is going to be reworked, I see this as more of an advisory about what to avoid rather than a patch that can be applied.

This has changed in 7.x already, and we can't do this in 6.x at this stage.