Link to new comment with #anchor genarated not correctly. String
array('attributes' => array('title' => $comment->subject, 'fragment' => 'comment-'. $comment->cid))

must be
array('attributes' => array('title' => $comment->subject), 'fragment' => 'comment-'. $comment->cid )

I found some missing translation, but I'm not shure that my fix is correctly (it's work for me). Please review patch.

CommentFileSizeAuthor
#4 userpoints.module.patch1.43 KBdicreat
#2 userpoints.module.patch779 bytesdicreat
userpoints.module.patch1.61 KBdicreat

Comments

kbahey’s picture

kbahey commented
Title: Missing translation and wrong anchor tag to comment » Wrong anchor tag to comment
Status: Needs review » Needs work

t() should not be used on variables, only literal strings.

See details here http://groups.drupal.org/node/15177

You can submit a revised patch for the anchor issue only.

dicreat’s picture

dicreat commented
StatusFileSize
new userpoints.module.patch779 bytes

Ok, thanks.

kbahey’s picture

kbahey commented

The patch does not apply cleanly. Please follow the instructions at http://drupal.org/patch for details.

Also, if you search the module you will find another instance of _comment_load(). Does the lines following it need to be fixed to? If so, please reroll the patch with a fix for that line as well.

dicreat’s picture

dicreat commented
StatusFileSize
new userpoints.module.patch1.43 KB

Please review new patch, now all must be fine.

kbahey’s picture

kbahey commented
Status: Needs work » Fixed

Committed. Thank you!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.