I got this warning when I landed at the project/issues/<project> page:
warning: Invalid argument supplied for foreach() in /home/alienbrain/projects/pool/issuetracking/src/drupal/sites/all/modules/project_issue/views/handlers/project_issue_handler_filter_issue_version.inc on line 105.
Looks like it's because I don't have any versions/releases. The filter already excludes itself on such case, but a check is needed in the handler's query() to make sure it won't do its thing if the filter was excluded and no value present.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | 432394_version_filter_1.patch | 2.99 KB | aclight |
| project_issue-version_filter_value_check-01.patch | 1.23 KB | AmrMostafa |
Comments
Comment #1
aclight commentedI marked #437670: Error when clicking on Project from the Issues view as a duplicate of this issue. That issue brought up the fact that we also weren't properly checking in init_version_info() of the same handler to make sure that one or more of the version terms was active. The attached patch makes that check, and also incorporates the check from alienbrain's patch in the original issue.
Comment #2
dennys commentedaclight's patch works for me, suggest to commit it, thanks.
Comment #3
leop commentedaclight's patch works for me as well
Comment #4
AmrMostafa commentedCome on people, you can RTBC! :)
(I didn't test aclight's patch since I don't suffer from the original issue he marked as dup)
Comment #5
dwwReproduced the bug, reviewed the patch, tested and confirmed the fix. All good. ;) Committed to HEAD. Thanks, folks!