Using the enter key or clicking 'save' - only the first posted microblog status 'takes ' - after that you've got to reload the page to make it work.

Comments

jeckman’s picture

jeckman commented
Assigned: jeckman » cfuller12

Chris - the issue is in lines 114-121 of microblog.module - commenting these out, it works again, but without the nice notification. Can you take a look and see if anything stands out to you?

cfuller12’s picture

cfuller12 commented
Version: 6.x-1.0 » 6.x-1.0.x-dev
Status: Active » Needs review

John - this one's fixed in HEAD. Just a bit of a problem with the AHAH implementation. Let me know if you see any other problems with it.

jeckman’s picture

jeckman commented

The submit works fine now, but the value of the text input in the form doesn't get reset.

You type a microblog entry, and hit enter/submit, the ahah fires with your update, but the form still contains your update - you have to delete it to submit a new update.

Also, the image doesn't seem to get properly set in the ahah version of the microblog update - you see the default admin image, and only see the correct user avatar when you reload the page.

cfuller12’s picture

cfuller12 commented

Ok, both of these items should be fixed now. The only thing that's still a potential issue is that the timestamps for previous tweets don't get updated when you submit a new post. This is because I'm just prepending the new post. The other approach would be to insert the new node into the db then query for all the nodes (either for the user timeline or public timeline depending on which page you're on). This would ultimately be more accurate but it's also significantly less efficient. I've currently opted for efficiency but I'm definitely willing to be convinced that we should do it the other way. Any thoughts on that?

Also, I've moved all (I think) of the output that was being generated in the pages.inc file into theme functions. If you agree that all of these items are fixed (and if you're ok with the prepend approach for now) it might be worth doing a release.

jeckman’s picture

jeckman commented

Thanks Chris - looks good. I agree it's better to only have the times update on full page refresh - I do plan to issue a release shortly.

jeckman’s picture

jeckman commented
Assigned: cfuller12 » jeckman
Status: Needs review » Closed (fixed)

Meant to close

Lee-vit-Over’s picture

Lee-vit-Over commented

Forgive me guys - not nearly as knowledgeable as yourselves. May I ask, as I think it pertains, in my Microblog the "Save" button is totally gone - missing - and there's no way to enter a Microblog at all and 'Save' it. I haven't used the Microblog (yet) but went to do a test-run and there's no "Save" or "Preview" button at all. Any idea why? -- I had it as a 'user profile content type', but removed it from that, thinking that was the problem. Still no "Save" button. I had version 6.1.1., but disabled and then un-installed it and installed 6.1.2 - Still no "Save" button. Am I doing something wrong, or missing something here, please?

Thanks!