Comply with node permissions ... Advertise these comment rss feeds with LINK tags in HEAD section of the page.

After this is committed, please edit this project home page and remove warning about node permissions.

I hope to add 4.7 compatibility and improve hook_menu() [each feed gets its own callback] in a future patch.

CommentFileSizeAuthor
commentrss.patch6.09 KBmoshe weitzman

Comments

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Reviewed & tested by the community

Good one Moshe. My comments:

  • $items = array(); was there so that $items[] is not adding an item to a nonexistent variable. This is bad PHP programming practice IMHO.
  • There are several modules to provide vocabulary listing pages, any or some of those pages can be checked for to advertise comment feeds. Vocabulary_list is such a module, but other taxonomy browser modules exist.

Otherwise this patch seems to be fine, feel free to commit.

moshe weitzman’s picture

moshe weitzman commented
Status: Reviewed & tested by the community » Fixed

I edited the project page accordingly

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)