Current state looks like

Q: [question]
A:
[detailed question]
[answer]

This all because detailed question attaches to node->body at hook_view

Patch changes this to faq_view_question

CommentFileSizeAuthor
#9 422780_faq_details.patch2.29 KBandypost
#7 422780_faq_details.patch1.79 KBandypost
#2 faq-detail.patch1.26 KBandypost
faq-detail.patch1.26 KBandypost

Comments

andypost’s picture

andypost
he/him
Primary language Russian
commented
Title: Detailed question should be undert question title » Detailed question should be under question title

This patch makes

Q: [question]
[detailed question]
A:
[answer]

andypost’s picture

andypost
he/him
Primary language Russian
commented
StatusFileSize
new faq-detail.patch1.26 KB

Patch against current DRUPAL-6--1

stella’s picture

stella commented
Status: Needs review » Fixed

Committed, though I had to fix it for the 'Clicking on question opens/hides the answer" layout as really the long question shouldn't appear until the short question was clicked.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Fixed » Needs review

You right, but now there's no ability to view a full node!!! All other 3 options hides long question forgiving about settings 'Question length' so long question is visible only on /faq page

I think that long question should depend only on "Question length" setting for /faq page and node-page

stella’s picture

stella commented
Status: Needs review » Postponed (maintainer needs more info)

Ok you're going to have to explain that better, because I'm not following your description.

andypost’s picture

andypost
he/him
Primary language Russian
commented

As descriptions said for the "question details" - it should be displayed at all layouts with answer and could replace short question on /faq page

Description of "Question length" radios is "The length of question text to display on the FAQ page. The short question will always be displayed in the FAQ blocks."
This setting for /faq page, I suppose...

Description of "Question details (optional)" field is "Longer question text. This will be displayed in all layouts where the answer appears, in addition to the shorter question text."
This tells that answer should be prefixed with this field, is not it?

Find another bug - "Question details" is displayed at top of node form (weight -1 against weight 0 for node-title)

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Postponed (maintainer needs more info) » Needs review
StatusFileSize
new 422780_faq_details.patch1.79 KB

I spend some time with debugger and check all values, it looks like something changed at theme layer so here patch:

1) Update a weight of node->title to show it before detailed question
2) Show detailed question before answer every-time when answer displayed

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Needs work

This happens only in INLINE mode, so going to dig deeper

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs work » Needs review
StatusFileSize
new 422780_faq_details.patch2.29 KB

Now it works as described above

stella’s picture

stella commented
Status: Needs review » Needs work

I've committed the node field weight change.

However I haven't committed the other change, as I said above, for the 'Clicking on question opens/hides the answer" layout, and when displaying both long and short questions, the long question shouldn't appear until the short question is clicked. Maybe the help text needs to be changed if that isn't clear.

stella’s picture

stella commented

Released in faq 6.x-1.9.

stella’s picture

stella commented
Status: Needs work » Fixed

No response, marking as fixed. Feel free to re-open if it's still an issue in the latest release.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.