The flag for the Korean language is missing. I have created one by scaling down the flag from the Wikipedia image which is public domain.

CommentFileSizeAuthor
ko.png567 bytesCito

Comments

cookiesunshinex’s picture

I downloaded the famfamfam icon flags and added the Korean one from there, but I had to change the filename from kr.png to ko.png to match the korean language translation

http://www.famfamfam.com/lab/icons/flags/

Freso’s picture

@ cookiesunshinex: That's because "kr" is the country code for South Korea, but we're working with language codes here. The language code "kr" corresponds to the Kanuri language.

@ Cito: Great! I'll have it added before the next release. Thank you. :)

Cito’s picture

As a side note, The famfam set has actually - politically correct - flags for both South and North Korea. But since the Internet is irrelevant in North Korea anyway, I think it's reasonable to use the South Korean flag. We need to be pragmatic. If you take it seriously, then using flags for languages is actually a heresy anyway (http://www.cs.tut.fi/~jkorpela/flags.html).

Freso’s picture

If you want to just use the names for the languages as links, you do not need this module at all. The links are provided by core's Locale (and Content Translation) module(s), which are pure text. If someone would like to add an icon set stylising the language codes, that'd be great - or they could just not use this module and change the text of the language links to e.g. "[lc]".

I also did not challenge the use of the South Korean flag for being used for Korean. I simply noted that the language code and the country code "kr" are two entirely different things (ie. Kanuri and South Korea, respectively). To take another example the other way around: I live in Denmark, where we speak Danish. When I have to tell where I come from, the code is "DK", when I have to name what I speak, the code is "da".

Freso’s picture

From http://en.wikipedia.org/wiki/Flag_of_Korea I notice that there is also a "Korean Unification Flag", used to represent the whole of Korea when North and South participate together in sporting events.

Perhaps this would be better to use as the default Korean flag?

Freso’s picture

Status: Active » Postponed (maintainer needs more info)
Freso’s picture

Category: feature » task
markwk’s picture

Version: 6.x-2.x-dev » 7.x-1.0-beta1

Korean flag not showing up in D7.

Freso’s picture

Version: 7.x-1.0-beta1 » 7.x-1.x-dev

Because it still has to be added. :)

ktdann’s picture

@Freso: Korean Unification Flag does represent the whole of Korea as it depicts Korean Peninsula. However, I've never seen anywhere else using this flag other than major sporting events where both nations participate. To simply put, this is not well known flag. If purpose of this module is to put a flag next to a language and that flag be well-known enough to do its job, I say it is more practical to use flag of Republic of Korea (i.e. South Korea). As Cito pointed out, "We need to be pragmatic."

This may be very silly way of saying it but ... If we view the internet as a sporting event, then we hardly see anyone from People republic of Korea(i.e. north korean) participating. So, there really is no reason to talk about Korean Unification Flag. :)

ktdann’s picture

Category: task » support
Status: Postponed (maintainer needs more info) » Active

Addition to what I said before, Will you be needing the file? I'm not sure if you already have one from the past or not. It does date back a little :P

- Update -
Forget what I said. Didn't realize that original link from Cito still works.

Freso’s picture

Category: support » task
Status: Active » Fixed

Alright, thanks for the input ktdann. :) (Why did you change it to a support request though?)

The flag from #0 has been committed to 7.x-1.x and 6.x-2.x.

ktdann’s picture

@ Fresco: I wasn't sure what to set it to actually. While fiddling around with the priority and status, I got carried away :P
Thanks for the commit.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.