Offshoot from #345984: Client-side caching of administration menu:

Administration menu should implement hook_js() (http://drupal.org/project/js) for faster AJAX requests. Only when the menu needs to be completely rebuilt, we need a full bootstrap.

CommentFileSizeAuthor
#4 admin_menu-no_locale.patch748 bytessmk-ka
#1 admin_menu-DRUPAL-5--3.js_.patch3.73 KBsun

Comments

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Active » Needs review
StatusFileSize
new admin_menu-DRUPAL-5--3.js_.patch3.73 KB
smk-ka’s picture

smk-ka commented
Status: Needs review » Reviewed & tested by the community

Works as advertised.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Reviewed & tested by the community » Fixed

Committed.

Though we probably need to fix:

+      // 'locale' additionally required, but only if enabled.
+      'dependencies' => array('locale', 'devel', 'filter', 'user'),

in js.php itself. IIRC, Locale module resp. locale() breaks when it is loaded without actually being installed.

smk-ka’s picture

smk-ka commented
Status: Fixed » Needs review
StatusFileSize
new admin_menu-no_locale.patch748 bytes

True. We should definitely remove the dependency, because JS is responsible for properly initializing locale, but not modules that make use of JS.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Fixed

Committed to all 3.x branches now. js.php probably needs to be updated for 6.x+, but that's a separate issue.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.