Seems to break DHTML Menu [#419082]

Comment	File	Size	Author
#2	me-419082.patch	2.85 KB	cdale

Comment #1

cdale CreditAttribution: cdale commented 31 March 2009 at 06:01

Yup, it will do that. HAHA. Damn :(

The problem appears to be that both modules attempt to override theme_menu_item_link. I'll need to ponder on this one.

Log in or register to post comments

Comment #2

cdale CreditAttribution: cdale commented 31 March 2009 at 06:08

Status:

Active

» Needs review

File	Size
me-419082.patch	2.85 KB

I've just put together a patch that I hope will fix this. Can you apply the patch and let me know if it is still broken? I'll try and install DHTML Menu in the mean time. Be sure to clear all your caches before passing final verdict. :)

Log in or register to post comments

Comment #3

fred0 CreditAttribution: fred0 commented 31 March 2009 at 06:25

Wow! Speedy response!
Yeah... that seems to fix it. Also seems to fix another issue I was seeing that broke the display of tabs in my custom genesis based theme.

However, now that it works, it looks like the use I had intended isn't supported... I had hoped to make custom menu items but trying to add a menu item with the path /user/me or /user/me/whatever fails. Is this not a valid use of this module?

Log in or register to post comments

Comment #4

cdale CreditAttribution: cdale commented 31 March 2009 at 06:35

hmmm... you should be able to add a custom menu item with path user/me... I just did a test myself with both "user/me" and "user/me/edit".

I'm assuming that user/[uid]/whatever are valid paths that drupal knows about? If not, then no, the me module just allows the 'insertion' of 'me' in a place where a uid would normally be required, and dynamically swaps it out with the current users uid when the path is hit.

Did you try creating the paths without the leading slash? I don't think the leading slash is supported there. Drupal takes care of making sure the slash is put in when needed.