Trailing space and indentation fix.
No functional change..

CommentFileSizeAuthor
#8 415944-8-code_style.patch8.09 KBpasqualle
#6 415944-6-code_style.patch23.82 KBpasqualle
#4 415944-4-code_style.patch52.06 KBpasqualle
#2 415944-2-code_style_l10n_groups.patch8.38 KBpasqualle
code_style.patch73.35 KBpasqualle

Comments

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Postponed

Good. I'd be happy to commit such fixes if there were no major patches waiting in the queue. As it stands, committing this patch would only break those patches, however those improve on performance which is more important for drupal.org deployment in the short run. Maybe help out testing there? :)

pasqualle’s picture

pasqualle
Location 🇭🇺 Budapest
commented
Title: Code style: whitespace » Code style
Status: Postponed » Needs review
StatusFileSize
new 415944-2-code_style_l10n_groups.patch8.38 KB

many code style fixes were committed since then, so starting over.

this patch is for l10n_groups module only; with the following changes:
1. no need to pass $node by reference in hook_insert/update/delete
2. do not translate schema descriptions
3. fixed some comments
4. trailing spaces

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Fixed

Thanks, committed.

pasqualle’s picture

pasqualle
Location 🇭🇺 Budapest
commented
Status: Fixed » Needs review
StatusFileSize
new 415944-4-code_style.patch52.06 KB

changes in this patch:
1. trailing spaces
2. indentation
3. some weird line breaks
4. else if

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Needs work

$ patch -p0 < 415944-4-code_style.patch.txt
patching file l10n_community/export.inc
patching file l10n_community/import.inc
patching file l10n_community/l10n_community.module
patching file l10n_community/moderate.inc
patch: **** malformed patch at line 254:

pasqualle’s picture

pasqualle
Location 🇭🇺 Budapest
commented
Status: Needs work » Needs review
StatusFileSize
new 415944-6-code_style.patch23.82 KB

patch #4 works for me.

the problem might be the windows style line ends in some parts of the moderate.inc and translate.inc files. It seems like I can't really make a working patch for you for those files, it would be nice if you could fix the line break problems in those files.

this patch is the same as #4, just the problematic files are removed from it..

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Fixed

Ok committed this with the re-saved translate.inc and moderate.inc with Unix newlines. Thanks again.

pasqualle’s picture

pasqualle
Location 🇭🇺 Budapest
commented
Priority: Normal » Minor
Status: Fixed » Needs review
StatusFileSize
new 415944-8-code_style.patch8.09 KB

ok, the line breaks seems good now

and the remaining trailing spaces from these files.
(yes it is my IDE creating these patches, you should find this setting also)

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Fixed

Committed with even more of these fixes, thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.